Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to skip .sif transfers and allow for relative mkmf template paths #343

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Feb 4, 2025

Describe your changes

Adds two features that make the code a bit more portable, should make it a lot easier to use fre-cli on systems that aren't gaea.

  • relative mkmf template paths - if a filename is given for the mkmf template (ie. no / in the string), it'll use the copy of the given template file that is stored in this repository as a submodule.
  • -nft/--no-format-transfer option for create-dockerfile and run-fremake. This removes the .sif file transfer step from the container build script.

Issue ticket number and link (if applicable)

#309

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@rem1776 rem1776 requested a review from ilaflott February 4, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant