User/f1p/merge gex ddep #49
Open
+47
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienpaulot
requested review from
uramirez8707,
laurenchilutti and
thomas-robinson
as code owners
|
@rem1776 You will need these changes as well for FMScoupler |
coupled/atmos_model.F90
Outdated
Comment on lines
699
to
700
| Atmos%gust (is:ie,js:je), & | ||
| gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:) ) |
There was a problem hiding this comment.
Is there a atmos_phys update needed for this?
|
yes, you need this tag.
lwh_am4p5dev_20241007
Thanks. Fabien
…On Thu, Feb 13, 2025 at 8:21 AM uramirez8707 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In coupled/atmos_model.F90
<#49 (comment)>
:
> + Atmos%gust (is:ie,js:je), &
+ gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:) )
Is there a atmos_phys update needed for this?
—
Reply to this email directly, view it on GitHub
<#49 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKAQA47SAXOVX6XLFS22WK32PSL67AVCNFSM6AAAAABV66GIYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJUHE3TOOBRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@fabienpaulot Can a merge request be opened in atmos_phys? We are going to need to cherry-pick those updates to am5_phys as well. |
uramirez8707
approved these changes
Feb 27, 2025
Comment on lines
+161
to
+162
| real, pointer, dimension(:,:,:) :: gex_atm2lnd =>null() | ||
| real, pointer, dimension(:,:,:) :: gex_lnd2atm =>null() |
There was a problem hiding this comment.
These two variables need to be added to atmos_data_type in atmos_null and atmos_solo_land
| @@ -214,6 +218,7 @@ module atmos_model_mod | |||
| real, dimension(:,:), pointer :: rough_heat =>null() ! surface roughness (used for heat) ! kgao | |||
| real, dimension(:,:), pointer :: frac_open_sea =>null() ! non-seaice fraction (%) | |||
| real, dimension(:,:,:), pointer :: data =>null() !collective field for "named" fields above | |||
| real, dimension(:,:,:), pointer :: gex_lnd2atm =>null() ! gex fields exchanged from lnd to atm | |||
There was a problem hiding this comment.
This variable needs to be added to atmos_null and atmos_solo_land
Comment on lines
+548
to
+549
| gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:), & | ||
| gex_lnd2atm = Surface_boundary%gex_lnd2atm(isw:iew,jsw:jew,:), & |
There was a problem hiding this comment.
The physics_driver_down interface needs to be updated in atmos_phys and am5_phys
Comment on lines
+702
to
+704
| Atmos%gust (is:ie,js:je), & | ||
| gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:), & | ||
| gex_lnd2atm = Surface_boundary%gex_lnd2atm(isw:iew,jsw:jew,:) ) |
There was a problem hiding this comment.
The physics_driver_up interface needs to be updated in atmos_phys and am5_phys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Save required fields in restart for gex
Fixes # (issue)
N/A
How Has This Been Tested?
ESM4.5
Checklist: