-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/f1p/merge gex ddep #49
base: main
Are you sure you want to change the base?
Conversation
@rem1776 You will need these changes as well for FMScoupler |
coupled/atmos_model.F90
Outdated
Atmos%gust (is:ie,js:je), & | ||
gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a atmos_phys update needed for this?
yes, you need this tag.
lwh_am4p5dev_20241007
Thanks. Fabien
…On Thu, Feb 13, 2025 at 8:21 AM uramirez8707 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In coupled/atmos_model.F90
<#49 (comment)>
:
> + Atmos%gust (is:ie,js:je), &
+ gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:) )
Is there a atmos_phys update needed for this?
—
Reply to this email directly, view it on GitHub
<#49 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKAQA47SAXOVX6XLFS22WK32PSL67AVCNFSM6AAAAABV66GIYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJUHE3TOOBRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@fabienpaulot Can a merge request be opened in atmos_phys? We are going to need to cherry-pick those updates to am5_phys as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made some comments for documentation to help keep track of things.
real, pointer, dimension(:,:,:) :: gex_atm2lnd =>null() | ||
real, pointer, dimension(:,:,:) :: gex_lnd2atm =>null() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two variables need to be added to atmos_data_type
in atmos_null and atmos_solo_land
@@ -214,6 +218,7 @@ module atmos_model_mod | |||
real, dimension(:,:), pointer :: rough_heat =>null() ! surface roughness (used for heat) ! kgao | |||
real, dimension(:,:), pointer :: frac_open_sea =>null() ! non-seaice fraction (%) | |||
real, dimension(:,:,:), pointer :: data =>null() !collective field for "named" fields above | |||
real, dimension(:,:,:), pointer :: gex_lnd2atm =>null() ! gex fields exchanged from lnd to atm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable needs to be added to atmos_null and atmos_solo_land
gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:), & | ||
gex_lnd2atm = Surface_boundary%gex_lnd2atm(isw:iew,jsw:jew,:), & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The physics_driver_down
interface needs to be updated in atmos_phys and am5_phys
Atmos%gust (is:ie,js:je), & | ||
gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:), & | ||
gex_lnd2atm = Surface_boundary%gex_lnd2atm(isw:iew,jsw:jew,:) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The physics_driver_up
interface needs to be updated in atmos_phys and am5_phys
Description
Save required fields in restart for gex
Fixes # (issue)
N/A
How Has This Been Tested?
ESM4.5
Checklist: