Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/f1p/merge gex ddep #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fabienpaulot
Copy link

Description

Save required fields in restart for gex

Fixes # (issue)

N/A

How Has This Been Tested?
ESM4.5

Checklist:

  • My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
@fabienpaulot
Copy link
Author

@rem1776 You will need these changes as well for FMScoupler

Comment on lines 699 to 700
Atmos%gust (is:ie,js:je), &
gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:) )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a atmos_phys update needed for this?

@fabienpaulot
Copy link
Author

fabienpaulot commented Feb 13, 2025 via email

@uramirez8707
Copy link

@fabienpaulot Can a merge request be opened in atmos_phys? We are going to need to cherry-pick those updates to am5_phys as well.

Copy link

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made some comments for documentation to help keep track of things.

Comment on lines +161 to +162
real, pointer, dimension(:,:,:) :: gex_atm2lnd =>null()
real, pointer, dimension(:,:,:) :: gex_lnd2atm =>null()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two variables need to be added to atmos_data_type in atmos_null and atmos_solo_land

@@ -214,6 +218,7 @@ module atmos_model_mod
real, dimension(:,:), pointer :: rough_heat =>null() ! surface roughness (used for heat) ! kgao
real, dimension(:,:), pointer :: frac_open_sea =>null() ! non-seaice fraction (%)
real, dimension(:,:,:), pointer :: data =>null() !collective field for "named" fields above
real, dimension(:,:,:), pointer :: gex_lnd2atm =>null() ! gex fields exchanged from lnd to atm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable needs to be added to atmos_null and atmos_solo_land

Comment on lines +548 to +549
gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:), &
gex_lnd2atm = Surface_boundary%gex_lnd2atm(isw:iew,jsw:jew,:), &

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The physics_driver_down interface needs to be updated in atmos_phys and am5_phys

Comment on lines +702 to +704
Atmos%gust (is:ie,js:je), &
gex_atm2lnd = Atmos%gex_atm2lnd(is:ie,js:je,:), &
gex_lnd2atm = Surface_boundary%gex_lnd2atm(isw:iew,jsw:jew,:) )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The physics_driver_up interface needs to be updated in atmos_phys and am5_phys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants