[F32] Fixes to translate test infrastructure & metric #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #67 up-skilled the translate test to be able to do 32-bit float and introduces a new metric named
MultiModalMetric
to be able to measure differences at 32-bit float via a mix of different metrics.This PR aim to fix a couple of missed bugs
make_storage_data
. We rely know on the input array being correct instead of trying to fix them. Any incorrect data type should be dealt with in theserialbox
side OR as a verbose cast in the test itself.Checklist: