Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F32] Constants must default to the system-wide floating point precision #88

Merged

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Dec 9, 2024

Make sure all constants adhere to the floating point precision set by Float

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency sake, we should probably make sure we specify units where applicable for all constants. Your thoughts?

ndsl/constants.py Outdated Show resolved Hide resolved
fmalatino
fmalatino previously approved these changes Dec 10, 2024
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck
Copy link
Collaborator Author

For consistency sake, we should probably make sure we specify units where applicable for all constants. Your thoughts?

Yes, indeed why not. I've duplicated the comments.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks or taking care of this

@FlorianDeconinck FlorianDeconinck merged commit cf4c2ce into NOAA-GFDL:develop Dec 11, 2024
5 checks passed
@FlorianDeconinck FlorianDeconinck deleted the fix/F32/Constants branch December 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants