[Serialbox to Netcdf tool] Collapse all rank into 1 if rank have different sized data #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollapse Clean up type infer and log work
fmalatino
previously approved these changes
Oct 24, 2024
fmalatino
approved these changes
Nov 13, 2024
oelbert
approved these changes
Nov 13, 2024
| dataset = xr.Dataset(data_vars=data_vars) | ||
| dataset.to_netcdf( | ||
| os.path.join(output_path, f"{savepoint_name}.nc"), encoding=encoding | ||
| ) | ||
|
|
||
|
|
||
| def get_data_collapse_all_ranks(total_ranks, n_savepoints, output_list, varname): | ||
| if total_ranks <= 0: |
There was a problem hiding this comment.
<= 0? Can we have negative total_ranks??
There was a problem hiding this comment.
Probably not but I did a bot of "defensive coding" here. If we pass -1 for any reason we don't crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are developing a new capacity of serialbox to append scalars to a one dimension array. This can be used to save data within iterative solver. This means that the number of data point save can vary by rank, so we have developed a solution to collapse all ranks into one to fit with the Translate test system. E.g.:
How Has This Been Tested?
Locally
Checklist: