Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo that breaks bools in translate tests #80

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fixing a typo that breaks bools in translate tests #80

merged 1 commit into from
Oct 10, 2024

Conversation

oelbert
Copy link
Collaborator

@oelbert oelbert commented Oct 9, 2024

Description
There is a typo in the translate test class that causes crashes with bool test data

How Has This Been Tested?
Tests don't crash with this fix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

FlorianDeconinck
FlorianDeconinck approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, that's one burning hotfix

fmalatino
fmalatino approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests pass will merge

@oelbert oelbert merged commit e17539d into NOAA-GFDL:develop Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalatino fmalatino fmalatino approved these changes

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oelbert @FlorianDeconinck @fmalatino