update lint

.github/workflows/fv3_translate_tests.yaml

@@ -1,10 +1,10 @@
-name: "FV3 Translate tests"
+name: "FV3 translate tests"
 on:
   pull_request:
-      types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]
 
 jobs:
-  all_tests:
+  fv3_translate_tests:
     uses: NOAA-GFDL/pyFV3/.github/workflows/translate.yaml@develop
     with:
-      ndsl_trigger:  true
+      component_trigger:  true
+      component_name: NDSL

.github/workflows/lint.yaml

@@ -1,7 +1,6 @@
 name: "Lint"
 on:
   pull_request:
-      types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]
 
 # cancel running jobs if theres a newer push
 concurrency:

.github/workflows/pace_tests.yaml

@@ -1,10 +1,10 @@
-name: "pace unit tests"
+name: "pace main tests"
 on:
   pull_request:
-      types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]
 
 jobs:
-  pace_unit_tests:
+  pace_main_tests:
     uses: NOAA-GFDL/pace/.github/workflows/main_unit_tests.yaml@develop
     with:
-      ndsl_trigger:  true
+      component_trigger:  true
+      component_name: NDSL

.github/workflows/shield_tests.yaml

@@ -1,10 +1,10 @@
 name: "SHiELD Translate tests"
 on:
   pull_request:
-      types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]
 
 jobs:
   shield_translate_tests:
     uses: NOAA-GFDL/pySHiELD/.github/workflows/translate.yaml@develop
     with:
-      ndsl_trigger:  true
+      component_trigger:  true
+      component_name: NDSL

.github/workflows/unit_tests.yaml

@@ -1,29 +1,33 @@
-name: "NDSL Unit tests"
+name: "NDSL unit tests"
 on:
   pull_request:
-      types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled]
 
 # cancel running jobs if theres a newer push
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
-  all_ndsl_tests:
+  ndsl_unit_tests:
     runs-on: ubuntu-latest
     container:
       image: ghcr.io/noaa-gfdl/miniforge:mpich
     steps:
+
         - name: Checkout repository
           uses: actions/checkout@v4
           with:
             submodules: 'recursive'
+
         - name: Install Python packages
           run: pip3 install .[test]
+
         - name: Run serial-cpu tests
           run: coverage run --rcfile=setup.cfg -m pytest -x tests
+
         - name: Run parallel-cpu tests
           run: mpiexec -np 6 --oversubscribe coverage run --rcfile=setup.cfg -m mpi4py -m pytest -x tests/mpi
+
         - name: Output code coverage
           run: |
             coverage combine

ndsl/stencils/corners.py

@@ -989,6 +989,7 @@ def fill_corners_dgrid_defn(
     x_out: FloatField,
     y_in: FloatField,
     y_out: FloatField,
+    mysign: float,
 ):
     """
     Args:
@@ -997,7 +998,7 @@ def fill_corners_dgrid_defn(
         y_in (in):
         y_out (inout):
     """
-    from __externals__ import i_end, i_start, j_end, j_start, mysign
+    from __externals__ import i_end, i_start, j_end, j_start
 
     with computation(PARALLEL), interval(...):
         # sw corner