Eliminate unneeded diagnostic arrays in CorAdCalc #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminated 4 unnecessary 3-d allocatable arrays and 8 2-d diagnostic arrays in CorAdCalc, and simplified the code calculating these diagnostics by using the post_product_[uv] and post_product_sum_[uv] routines. Also grouped the calls that allocate the memory that is still needed for diagnostics. This commit also includes a few other minor changes to clean up the documentation of variable intents and unit documentation in a handful of other places in the code: - Add intent declarations to the arguments to chksum2d() and chksum3d() - Corrected incorrect scale arguments for two (untested) checksum calls. - Corrected the documented units in several comments. All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #52 +/- ##
============================================
- Coverage 28.96% 28.92% -0.05%
============================================
Files 242 242
Lines 71324 71233 -91
============================================
- Hits 20660 20601 -59
+ Misses 50664 50632 -32
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14445 ✔️ |
marshallward
approved these changes
Dec 27, 2021
This was referenced Jan 29, 2022
Hallberg-NOAA
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated 4 unnecessary 3-d allocatable arrays and 8 2-d diagnostic arrays
in CorAdCalc, and simplified the code calculating these diagnostics by using the
post_product_[uv] and post_product_sum_[uv] routines. Also grouped the calls
that allocate the memory that is still needed for diagnostics.
This commit also includes a few other minor changes to clean up the
documentation of variable intents and unit documentation in a handful of other
places in the code:
Add intent declarations to the arguments to chksum2d() and chksum3d()
Corrected incorrect scale arguments for two (untested) checksum calls.
Corrected the documented units in several comments.
All answers and output are bitwise identical.