Correct out of bounds index (por_face_areaU) bug #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the expressionfs for the por_face_areaU arguments being passed to zonal_face_thickness to avoid the array out-of-bounds index errors highlighted in MOM6 issue mom-ocean#24. Also added comments noting where the por_face_area arrays should probably be included in the effective (relative) face thickness calculations that are later used for finding the vertically averaged accelerations by the barotropic solver. All answers and output are bitwise identical in cases that work, but this should avoid some run-time or compile-time errors with some compiler settings.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #32 +/- ##
=========================================
Coverage 29.05% 29.05%
=========================================
Files 240 240
Lines 71293 71293
=========================================
+ Hits 20712 20714 +2
+ Misses 50581 50579 -2
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14315 ✔️ |
marshallward
approved these changes
Dec 10, 2021
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the expressionfs for the por_face_areaU arguments being passed to
zonal_face_thickness()to avoid the array out-of-bounds index errors highlighted inMOM6 issue #24. Also added comments noting where the por_face_area arrays should
probably be included in the effective (relative) face thickness calculations that are
later used for finding the vertically averaged accelerations by the barotropic solver.
All answers and output are bitwise identical in cases that work, but this should
avoid some run-time or compile-time errors with some compiler settings.