Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add NASA-GMAO to consortium figure #31

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

marshallward
Copy link
Member

This patch updates the PNG file of the consortiums in the docs to
include the NASA-GMAO group.

This patch updates the PNG file of the consortiums in the docs to
include the NASA-GMAO group.
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #31 (d3e4db2) into dev/gfdl (7ae28b8) will not change coverage.
The diff coverage is n/a.

❗ Current head d3e4db2 differs from pull request most recent head 8824671. Consider uploading reports for the commit 8824671 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #31   +/-   ##
=========================================
  Coverage     29.00%   29.00%           
=========================================
  Files           240      240           
  Lines         71237    71237           
=========================================
  Hits          20665    20665           
  Misses        50572    50572           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae28b8...8824671. Read the comment docs.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, but why doesn't NASA/GMAO get any users or their favorite color? In some more elaborate later version, we could perhaps consider replacing the plain circles with the logo-badges of each of their Institutions? If there is one thing that we can all learn from NASA, it is how to do branding right!

@Hallberg-NOAA Hallberg-NOAA merged commit 8f5dc28 into NOAA-GFDL:dev/gfdl Dec 13, 2021
@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Feb 1, 2022
@marshallward marshallward deleted the consortium_fig_update branch March 8, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants