Standardize the output of tiny real values #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to harmonize differences in how different compilers format the output of tiny (< 1e-99) or huge (>= 1e100) real values. All answers are bitwise identical, but output could change with the PGI compiler for any cases that are writing out such extreme values.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #302 +/- ##
============================================
- Coverage 37.07% 37.07% -0.01%
============================================
Files 263 263
Lines 73656 73666 +10
Branches 13722 13727 +5
============================================
+ Hits 27308 27310 +2
- Misses 41310 41315 +5
- Partials 5038 5041 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
reviewed
Jan 6, 2023
|
Have you tested the formatted output reads in correctly? The goal is to have a fixed output that also works as input. |
|
Yes. I have recycled the revised lines from the output files back to the MOM_input files. This is how I tested that these changes also work for logging 1.0E+150 as well as 1.0E-150. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17896 ✔️ This restores the old answers, and (via @Hallberg-NOAA) is readable by PGI. |
marshallward
approved these changes
Jan 7, 2023
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to harmonize differences in how different compilers format the output of tiny (< 1e-99) or huge (>= 1e100) real values. All answers are bitwise identical, but output could change with the PGI compiler for any cases that are writing out such extreme values.