Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indexing of array passed to data_override. #30

Merged

Conversation

wfcooke
Copy link

@wfcooke wfcooke commented Dec 6, 2021

The arrays passed to data_overrride need to be sized as the compute
domain. Added indices to pass to data_override.

The arrays passed to data_overrride need to be sized as the compute
domain. Added indices to pass to data_override.
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #30 (429e56b) into dev/gfdl (ec553aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #30   +/-   ##
=========================================
  Coverage     29.05%   29.05%           
=========================================
  Files           240      240           
  Lines         71293    71293           
=========================================
  Hits          20712    20712           
  Misses        50581    50581           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec553aa...429e56b. Read the comment docs.

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct and is consistent with the other drivers.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14313 ✔️

@marshallward marshallward merged commit 3364af1 into NOAA-GFDL:dev/gfdl Dec 10, 2021
@Hallberg-NOAA Hallberg-NOAA added the bug Something isn't working label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants