+Add units to 11 log_param calls #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #262 +/- ##
=========================================
Coverage 37.12% 37.13%
=========================================
Files 263 263
Lines 73444 73444
Branches 13675 13675
=========================================
+ Hits 27268 27270 +2
+ Misses 41151 41148 -3
- Partials 5025 5026 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
force-pushed
the
log_param_units
branch
from
1997c02 to
7eacb9e
Compare
Add appropriate units arguments to 11 log_param calls that were missing them. All answers are bitwise identical, but the logged output can change in some cases.
Hallberg-NOAA
force-pushed
the
log_param_units
branch
from
7eacb9e to
2ba9c1d
Compare
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17698 ✔️ |
marshallward
approved these changes
Dec 14, 2022
This was referenced Apr 6, 2023
marshallward
pushed a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add appropriate units arguments to 11 log_param calls that were missing them.
All answers are bitwise identical, but the logged output can change in some cases.