Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Removed 31 meaningless get_param units #240

Merged

Conversation

Hallberg-NOAA
Copy link
Member

Removed meaningless units arguments from 31 get_param calls for integer, character, or logical parameters. All answers are bitwise identical, but some entries in the various parameter_doc files are changed.

  Removed meaningless units arguments from 31 get_param calls for integer,
character, or logical parameters.  All answers are bitwise identical, but some
entries in the various parameter_doc files are changed.
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #240 (c598825) into dev/gfdl (6765e27) will not change coverage.
The diff coverage is 58.33%.

❗ Current head c598825 differs from pull request most recent head 49bc435. Consider uploading reports for the commit 49bc435 to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #240   +/-   ##
=========================================
  Coverage     37.08%   37.08%           
=========================================
  Files           263      263           
  Lines         73388    73388           
  Branches      13677    13677           
=========================================
  Hits          27219    27219           
  Misses        41136    41136           
  Partials       5033     5033           
Impacted Files Coverage Δ
...ig_src/drivers/solo_driver/MOM_surface_forcing.F90 24.42% <0.00%> (ø)
src/parameterizations/lateral/MOM_hor_visc.F90 50.40% <0.00%> (ø)
src/parameterizations/vertical/MOM_CVMix_KPP.F90 0.80% <0.00%> (ø)
src/user/MOM_wave_interface.F90 1.31% <ø> (ø)
src/user/dumbbell_initialization.F90 0.00% <0.00%> (ø)
src/user/dumbbell_surface_forcing.F90 0.00% <0.00%> (ø)
src/core/MOM_barotropic.F90 58.96% <100.00%> (ø)
src/framework/MOM_unit_scaling.F90 63.10% <100.00%> (ø)
src/parameterizations/lateral/MOM_MEKE.F90 41.92% <100.00%> (ø)
...eterizations/lateral/MOM_lateral_mixing_coeffs.F90 42.74% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward
Copy link
Member

marshallward commented Nov 24, 2022

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17520 ✔️ 🟡

@marshallward marshallward merged commit 321e0eb into NOAA-GFDL:dev/gfdl Nov 24, 2022
@Hallberg-NOAA Hallberg-NOAA deleted the fewer_meaningless_units branch February 2, 2023 13:49
marshallward pushed a commit that referenced this pull request Oct 25, 2023
Improvements in the MOM_lateral_boundary_diffusion module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants