*Change defaults for KV_ML_INVZ2 and 3 bug flags #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the default values for KV_ML_INVZ2, BAROTROPIC_TIDAL_SAL_BUG, LAYER_Z_INIT_IC_EXTRAP_BUG, and KAPPA_SHEAR_VERTEX_PSURF_BUG. Also completed obsoleting of HENYEY_IGW_BACKGROUND_NEW. This PR will change answers in some cases, unless the MOM_input files already included lines with the following settings, or otherwise explicitly set these parameters: KV_ML_INVZ2 = 0.0 BAROTROPIC_TIDAL_SAL_BUG = False LAYER_Z_INIT_IC_EXTRAP_BUG = False KAPPA_SHEAR_VERTEX_PSURF_BUG = False For each of these parameters, there is another parameter (such as BULKMIXEDLAYER or TIDES) whose value determines whether they might be used in a particular case. To determine whether or why answers for a particular configuration might change with this PR, compare the MOM_parameter_doc.all files from equivalent runs before and after these code changes to determine whether any of these parameters are taking the default value. This commit could change answers in some cases that use default values for these parameters, and the entries in some MOM_parameter_doc files will change. The answers in the MOM6-examples test suite are bitwise identical, due to some entries that were recently added to the MOM_input files for these cases.
|
This PR changes answers in some cases, and some of the C.I. regression tests fall into this category. |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #205 +/- ##
============================================
+ Coverage 37.14% 37.18% +0.03%
============================================
Files 262 261 -1
Lines 72746 72418 -328
Branches 13598 13571 -27
============================================
- Hits 27023 26930 -93
+ Misses 40707 40486 -221
+ Partials 5016 5002 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16811 ✔️ 🟡 |
marshallward
approved these changes
Sep 20, 2022
chzhangudel
pushed a commit
to chzhangudel/MOM6
that referenced
this pull request
Sep 29, 2022
Add the Stokes Forces Implementation for the Surface Bands wave coupling method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the default values for KV_ML_INVZ2, BAROTROPIC_TIDAL_SAL_BUG,
LAYER_Z_INIT_IC_EXTRAP_BUG, and KAPPA_SHEAR_VERTEX_PSURF_BUG. Also completed obsoleting of HENYEY_IGW_BACKGROUND_NEW. This PR will change answers in some cases, unless the MOM_input files already included lines with the following settings, or otherwise explicitly set these parameters:
KV_ML_INVZ2 = 0.0
BAROTROPIC_TIDAL_SAL_BUG = False
LAYER_Z_INIT_IC_EXTRAP_BUG = False
KAPPA_SHEAR_VERTEX_PSURF_BUG = False
For each of these parameters, there is another parameter (such as BULKMIXEDLAYER or TIDES) whose value determines whether they might be used in a particular case. To determine whether or why answers for a particular configuration might change with this PR, compare the MOM_parameter_doc.all files from equivalent runs before and after these code changes to determine whether any of these parameters are taking the default value. This commit could change answers in some cases that use default values for these parameters, and the entries in some MOM_parameter_doc files will change. The answers in the MOM6-examples test suite are bitwise identical, due to some entries that were recently added to the MOM_input files for these cases.