Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the units of 124 variables #2

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

Hallberg-NOAA
Copy link
Member

Corrected the units in comments describing 124 variables in 39 files. In
addition three unused variables were eliminated. All answers and output are
bitwise identical.

  Corrected the units in comments describing 124 variables in 39 files.  In
addition three unused variables were eliminated.  All answers and output are
bitwise identical.
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #2 (5c74aee) into dev/gfdl (d7b2e32) will decrease coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl       #2      +/-   ##
============================================
- Coverage     29.15%   29.15%   -0.01%     
============================================
  Files           239      239              
  Lines         71462    71463       +1     
============================================
  Hits          20833    20833              
- Misses        50629    50630       +1     
Impacted Files Coverage Δ
src/ALE/MOM_ALE.F90 34.68% <0.00%> (ø)
src/core/MOM.F90 58.89% <ø> (ø)
src/core/MOM_PressureForce_FV.F90 32.81% <0.00%> (ø)
src/core/MOM_density_integrals.F90 9.39% <ø> (ø)
src/core/MOM_dynamics_split_RK2.F90 61.08% <ø> (ø)
src/core/MOM_forcing_type.F90 47.43% <0.00%> (ø)
src/core/MOM_verticalGrid.F90 70.21% <ø> (ø)
src/diagnostics/MOM_diagnostics.F90 76.40% <ø> (ø)
src/diagnostics/MOM_sum_output.F90 62.75% <ø> (ø)
src/diagnostics/MOM_wave_structure.F90 0.00% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b2e32...5c74aee. Read the comment docs.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14113 ✔️

@marshallward marshallward merged commit e2e5787 into NOAA-GFDL:dev/gfdl Nov 19, 2021
@Hallberg-NOAA Hallberg-NOAA deleted the fix_units_in_comments branch November 27, 2021 11:20
@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Feb 1, 2022
kshedstrom added a commit to ESMG/MOM6 that referenced this pull request Apr 12, 2024
- otherwise it doesn't compile without linking to COBALT due to
   COBALT interface updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants