Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ice shelf initialization #190

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

MJHarrison-GFDL
Copy link

  • Ice shelf needs to be initialized prior to
    ocean state initialization. This fixes any cases with
    an ice shelf using the FMScap.

  - Ice shelf needs to be initialized prior to
    ocean state initialization. This fixes any cases with
    an ice shelf using the FMScap.
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #190 (ce30357) into dev/gfdl (a22f691) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           dev/gfdl     #190   +/-   ##
=========================================
  Coverage     37.22%   37.22%           
=========================================
  Files           261      261           
  Lines         72334    72334           
  Branches      13533    13533           
=========================================
  Hits          26925    26925           
  Misses        40417    40417           
  Partials       4992     4992           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward
Copy link
Member

marshallward commented Aug 19, 2022

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16480 ✔️ 🟡

This patch alters the position of ICE_SHELF in the parameter output, so it needs an update.

@marshallward marshallward merged commit 9c5f77e into NOAA-GFDL:dev/gfdl Aug 20, 2022
@MJHarrison-GFDL MJHarrison-GFDL deleted the ice_shelf_FMScap_fix branch April 10, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants