Minor code cleanup in drivers/FMS_cap #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various minor code cleanup in the drivers/FMS_cap directory, including:
o Rescaled the internal latent_heat variables in the control structure for
MOM_surface_forcing_gfdl for improved dimensional consistency testing.
o Removed the unused local variable PmE_adj in convert_IOB_to_fluxes().
o Corrected the documented units or fixed spelling errors in several comments.
All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #14 +/- ##
=========================================
Coverage 29.17% 29.17%
=========================================
Files 240 240
Lines 71481 71481
=========================================
Hits 20852 20852
Misses 50629 50629 Continue to review full report at Codecov.
|
marshallward
approved these changes
Nov 30, 2021
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14235 ✔️ |
This was referenced Jan 29, 2022
Hallberg-NOAA
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor code cleanup in the drivers/FMS_cap directory, including:
All answers and output are bitwise identical.