Address compiler warnings for FV3 raised in an issue #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt from set_regional_BCs in fv_regional_bc.F90
DusanJovic-NOAA
approved these changes
Feb 28, 2024
|
Please remove |
|
@DusanJovic-NOAA - compiler flag update completed and typo fixed in test_cases.F90 |
|
I see the commit to solve the same issue in AQM production branch: NOAA-EMC@d334488 |
DusanJovic-NOAA
approved these changes
Mar 8, 2024
junwang-noaa
approved these changes
Mar 11, 2024
XiaqiongZhou-NOAA
approved these changes
Mar 12, 2024
DusanJovic-NOAA
approved these changes
Mar 29, 2024
This was referenced Apr 1, 2024
|
ufs-weather-model regression test passed, see ufs-community/ufs-weather-model#2218 |
|
@DusanJovic-NOAA - I just merged the top of the dev/emc trunk to ensure any testing contains the updates from PR #320 |
|
@bensonr Please sync this branch with dev/emc. |
|
@DusanJovic-NOAA - should be done, but please check to ensure. |
Thanks, looks good. |
zhanglikate
added a commit
to zhanglikate/GFDL_atmos_cubed_sphere
that referenced
this pull request
Apr 30, 2024
commit 9711488 Author: Rusty Benson <[email protected]> Date: Wed Apr 17 08:41:41 2024 -0400 Address compiler warnings for FV3 raised in an issue (NOAA-GFDL#324) * give istatus a value on exit from hailcast_init * fix issues with declared out variables in test_cases.F90 * fix out of range default integers, eol spaces, and remove delz argument from set_regional_BCs in fv_regional_bc.F90 * removed -nowarn from Intel compiler flags * added suggested ifdef to remove goto warning as per operations commit 0301022 Author: Samuel Trahan (NOAA contractor) <[email protected]> Date: Fri Apr 12 20:02:26 2024 -0400 nesting bug fixes for uninitialized variable in fv3 and incorrect tile number in fv3atm (NOAA-GFDL#331) * pass global tile up to model * bug fix: initialize hailwat variable commit f060e85 Author: Jaymes Kenyon <[email protected]> Date: Fri Mar 1 22:23:31 2024 -0500 Correct a bug in the HAILCAST diagnostic code (units issue) (NOAA-GFDL#320)
laurenchilutti
pushed a commit
to laurenchilutti/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 18, 2024
* give istatus a value on exit from hailcast_init * fix issues with declared out variables in test_cases.F90 * fix out of range default integers, eol spaces, and remove delz argument from set_regional_BCs in fv_regional_bc.F90 * removed -nowarn from Intel compiler flags * added suggested ifdef to remove goto warning as per operations
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the compiler warnings in fv_regional_bc.F90, test_cases.F90, and module_diag_hailcast.F90 as identified by NCO. Unfortunately the logic in fv_nudge.F90 is too complex to easily address the goto identified herein.
Fixes #307
How Has This Been Tested?
No tests have yet been run. I will ask the relevant EPIC team members to test when ready.
Checklist:
Please check all whether they apply or not