Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write restart files using the write grid component in UFS #244

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

DusanJovic-NOAA
Copy link
Contributor

Description

This PR adds new module that enables writing the restart files using the write grid component in UFS. The new module is located in driver/fvGFS/ and is only used by UFS.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the convention of north and east within FMS when referring to staggered variables. You are already using east and I suggest replacing south with north to keep the conventions the same.

@DusanJovic-NOAA
Copy link
Contributor Author

We use the convention of north and east within FMS when referring to staggered variables. You are already using east and I suggest replacing south with north to keep the conventions the same.

Done. See 83f596d

core_east_var3_names(1) = 'v'
n = 1
if (.not.atm%flagstruct%hydrostatic) then
if (atm%flagstruct%make_nh) then ! hydrostatic restarts dont have these variables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I understand correctly. But the lines 123-127 look the same as line 129-133, do we need this if statement?

n = 1
if (.not.atm%flagstruct%hydrostatic) then
if (atm%flagstruct%make_nh) then ! hydrostatic restarts dont have these variables
! core_center_var3(n) = 'w'; n=n+1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand this if statement (and comments) . Isn't line 208 said that this is non-hydrostatic? Can we have:

if (.not. atm%flagstruct%make_nh) then
 lines 216-220
endif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junwang-noaa
Copy link
Collaborator

We use the convention of north and east within FMS when referring to staggered variables. You are already using east and I suggest replacing south with north to keep the conventions the same.

Done. See 83f596d

@bensonr would you please review again? Thanks

@bensonr bensonr self-requested a review March 15, 2023 16:31
@jkbk2004
Copy link

all tests are done on ufs-community/ufs-weather-model#1633. @bensonr @laurenchilutti can you merge the pr?

@laurenchilutti laurenchilutti merged commit 9d5bed8 into NOAA-GFDL:dev/emc Mar 28, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the quilting_restart branch September 7, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants