Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update image with spack generated recipefile #1453

Merged
merged 19 commits into from
Apr 30, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Feb 6, 2024

Description
Updates the dockerfile to use a spack generated one instead of a handwritten one that uses spack. The spack.yml and Dockerfile.template file generate the image.

Updates to the newest versions of gcc/gfortran and the rest of dependencies (besides hdf5, due to the issue with the FPE trapping flag). Also adds the libgomp package, which may fix some openmp inconsistencies we've seen in the CI.

How Has This Been Tested?
FMS make check and coupler null model build

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

thomas-robinson
thomas-robinson previously approved these changes Feb 9, 2024
@rem1776
Copy link
Contributor Author

rem1776 commented Feb 13, 2024

@thomas-robinson gonna have to add one more commit to this PR, forgot I've been tagging the containers with the compiler versions they use so I'll need to update the tags used by the various workflows

@rem1776 rem1776 requested a review from bensonr as a code owner February 21, 2024 22:06
.github/container/Dockerfile.template Outdated Show resolved Hide resolved
.github/container/Dockerfile.gnu Outdated Show resolved Hide resolved
@rem1776 rem1776 merged commit ac22da2 into NOAA-GFDL:main Apr 30, 2024
18 of 20 checks passed
rem1776 added a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants