-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update image with spack generated recipefile #1453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
previously approved these changes
Feb 9, 2024
@thomas-robinson gonna have to add one more commit to this PR, forgot I've been tagging the containers with the compiler versions they use so I'll need to update the tags used by the various workflows |
bensonr
reviewed
Feb 21, 2024
bensonr
approved these changes
Apr 30, 2024
thomas-robinson
approved these changes
Apr 30, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the dockerfile to use a spack generated one instead of a handwritten one that uses spack. The spack.yml and Dockerfile.template file generate the image.
Updates to the newest versions of gcc/gfortran and the rest of dependencies (besides hdf5, due to the issue with the FPE trapping flag). Also adds the libgomp package, which may fix some openmp inconsistencies we've seen in the CI.
How Has This Been Tested?
FMS make check and coupler null model build
Checklist:
make distcheck
passes