Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file for diagnostic scripts and use it to generalize sst_eval.py #74

Merged
merged 10 commits into from
Aug 19, 2024

Conversation

uwagura
Copy link
Collaborator

@uwagura uwagura commented Aug 5, 2024

This pull request adds a config.yaml file to the physics diagnostics directory to make it easier to run the diagnostics scripts across domains by removing hardcoded variables. As a first test for the new config file, this PR also modifies the sst_eval.py script to use variables supplied by the config file. The script produces the same output as before for the NWA domain, but it can now be used across other domains as well by modifying the variables within the config file. Below is are the outputs from the script in the NWA and NEP domains using the new config file

sst_eval
sst_eval_nep_align
sst_eval_better_lims
sst_eval_arctic

@yichengt900
Copy link
Contributor

Hi @gabyneg and @theresa-morrison,

@uwagura is currently working on generalizing our diagnostic scripts to support multiple regional domains. Could you please share the post-processing (PP) paths on archive for the Hawaii and Arctic domains? They don't need to be the best results; we just want to test the script and ensure it functions correctly across different domains. Thanks!

@gabyneg
Copy link
Collaborator

gabyneg commented Aug 5, 2024

Hi @yichengt900 and @uwagura, my PP step has not been functioning properly, so I have been using my output from my history files e.g. : "/archive/g1n/fre/cefi/MHI/CEFI_MHI_COBALT_V2/gfdl.ncrc5-intel22-prod/history"

@yichengt900
Copy link
Contributor

@gabyneg, thanks, and no worries. If you are willing to share your example XML, perhaps @uwagura can try to help implement the PP step for the Pacific Islands.

@uwagura
Copy link
Collaborator Author

uwagura commented Aug 5, 2024

I can definitely look into the pp issue @gabyneg . And thanks for sharing the path to the history files!

@gabyneg
Copy link
Collaborator

gabyneg commented Aug 5, 2024

@uwagura Thank you! Here are my xml files (physics only) "/gpfs/f5/cefi/proj-shared/MHI/xmls/MHI/MHI_physics.xml", & (physics + bgc): "/gpfs/f5/cefi/proj-shared/MHI/xmls/MHI/CEFI_MHI_cobalt.xml".

@theresa-cordero
Copy link
Contributor

@yichengt900 Here is a path with pp for the full simulation period:
/archive/Theresa.Morrison/fre/cefi/ARC12/ARC12_51/gfdl.ncrc5-intel22-prod/pp

Note that Kate has adjusted a lot of parameters since I ran this experiment, so it is not the up-to-date state of the Arctic configuration!

@yichengt900
Copy link
Contributor

@theresa-morrison, thanks for sharing the path. No worries, the main goal here is to make sure the script can work with all the different domains we have, especially the Arctic one considering its unique grid projection. @uwagura, please give it a try for these two domains too, so we can ensure it works for all our existing regional domains except the Great Lakes.

@uwagura uwagura requested a review from yichengt900 August 19, 2024 15:31
@uwagura uwagura requested a review from andrew-c-ross August 19, 2024 15:31
Copy link
Contributor

@yichengt900 yichengt900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uwagura , thanks for your great work! The new plots look good. Approve.

@yichengt900 yichengt900 merged commit 33500c1 into main Aug 19, 2024
3 checks passed
@yichengt900 yichengt900 deleted the add_diagnostic_config branch September 10, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants