Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add updates for main and dev branch #62

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Add updates for main and dev branch #62

merged 5 commits into from
Feb 21, 2025

Conversation

k-doering-NOAA
Copy link
Member

What is the feature?

create dev and main branches of case studies.

  • build case studies on main and dev,
  • install main version of FIMS on main or any branch that includes the word "main"; install dev version of FIMS for any other branch (including the dev branch)

How have you implemented the solution?

Does the PR impact any other area of the project, maybe another repo?

k-doering-NOAA and others added 3 commits February 21, 2025 21:30
@k-doering-NOAA
issue #51: setup to use dev and main branch case studies
9d8f78f 
Co-authored-by Bai-Li-NOAA
<[email protected]>
@k-doering-NOAA @Bai-Li-NOAA
@Andrea-Havron-NOAA @alexjensen-NOAA
update installing FIMS code #51
11209f1 
Download main branch of Fims if using main in the feature branch name

Co-authored-by: Bai Li - NOAA <[email protected]>
Co-authored-by: Andrea-Havron-NOAA <[email protected]>
Co-authored-by: alexjensen-NOAA <[email protected]>
@k-doering-NOAA
Add documentation
5fe4629
@k-doering-NOAA
Copy link
Member Author

@kellijohnson-NOAA Could you review these changes? if everything looks ok, I think this can be merged into main, then we can create the dev branch off of main.

kellijohnson-NOAA
kellijohnson-NOAA requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@kellijohnson-NOAA kellijohnson-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment and one bug. But otherwise looks good.

@k-doering-NOAA
Copy link
Member Author

Thanks @kellijohnson-NOAA ! I think I fixed the issues, so go ahead and merge in if you agree it is ready.

kellijohnson-NOAA
kellijohnson-NOAA approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@kellijohnson-NOAA kellijohnson-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kellijohnson-NOAA kellijohnson-NOAA merged commit e2d90ef into main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellijohnson-NOAA kellijohnson-NOAA kellijohnson-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-doering-NOAA @kellijohnson-NOAA