Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature:] get_ss3_data() does not need to create -999 #57

Open
kellijohnson-NOAA opened this issue Feb 8, 2025 · 0 comments
Open

[feature:] get_ss3_data() does not need to create -999 #57

kellijohnson-NOAA opened this issue Feb 8, 2025 · 0 comments
Assignees
Labels
attribute: case study features Needed for a case study to match a production assessment attribute: low hanging 🍎 Easy to knock off in less than 1 day kind: feature New feature or request kind: refactor Restructure code to improve the implementation of FIMS P3 Low priority task theme: code cleanup

Comments

@kellijohnson-NOAA
Copy link
Contributor

Describe the situation that led to the request and a solution

get_ss3_data() does not need to add -999 values because FIMSFrame() now does this for you. The capability within get_ss3_data() should be checked against the internal FIMSFrame() capability to make sure that they are both doing the same thing and then removed.

Alternative solutions

No response

Statistical validity

No response

Additional context

@MOshima-PIFSC and @iantaylor-NOAA I assigned both of you but clearly this is pretty low-hanging 🥝 and just one of you could do it. Please assign yourself to this issue if you are available. This is not urgent but I hope to have it completed by 2025-02-28.

@kellijohnson-NOAA kellijohnson-NOAA added attribute: case study features Needed for a case study to match a production assessment attribute: low hanging 🍎 Easy to knock off in less than 1 day kind: feature New feature or request kind: refactor Restructure code to improve the implementation of FIMS P3 Low priority task theme: code cleanup labels Feb 8, 2025
@iantaylor-NOAA iantaylor-NOAA self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute: case study features Needed for a case study to match a production assessment attribute: low hanging 🍎 Easy to knock off in less than 1 day kind: feature New feature or request kind: refactor Restructure code to improve the implementation of FIMS P3 Low priority task theme: code cleanup
Projects
None yet
Development

No branches or pull requests

2 participants