Reorganize test data

[Bai-Li-NOAA]

What is the feature?

• This PR reorganizes test data and addresses issue [Developer Issue]: reorganize tests and clean up hacky data modifications when prepare test data #730

How have you implemented the solution?

• Use test fixtures to properly generate multiple combinations of available data
• Add integration tests to validate handling of missing values in the datasets

Does the PR impact any other area of the project, maybe another repo?

• Other branches will need to be rebased with updated tests.

[github-actions]

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

• Please use this checklist during your review, checking off items that you have verified are complete!
• For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
• Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
• Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
• PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
• Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

• The PR is requested to be merged into the appropriate branch (typically main)
• The code is well-designed.
• The functionality is good for the users of the code.
• Any User Interface changes are sensible and look good.
• The code isn’t more complex than it needs to be.
• Code coverage remains high, indicating the new code is tested.
• The developer used clear names for everything.
• Comments are clear and useful, and mostly explain why instead of what.
• Code is appropriately documented (doxygen and roxygen).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (586ab1c) to head (78532f8).
Report is 5 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #741      +/-   ##
==========================================
+ Coverage   68.71%   68.92%   +0.21%     
==========================================
  Files          44       44              
  Lines        4714     4714              
  Branches      197      197              
==========================================
+ Hits         3239     3249      +10     
+ Misses       1428     1418      -10     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kellijohnson-NOAA]

Thanks @Bai-Li-NOAA for these changes. I think this work is a great movement towards cleaning up the codebase as a whole and making things more consistent. I added two commits that should be squashed when you are ready. I do have a question about the sdr_report and the use of @.

[kellijohnson-NOAA]

How come the sdr_report is the estimates table?

[Bai-Li-NOAA]

I’ve updated the tests to use get_report() and get_estimates() when working with the wrapper functions.

[Bai-Li-NOAA]

@kellijohnson-NOAA, I have addressed the great suggestions! I wanted to note a few additional changes that may need further review:

• I've updated .vscode/settings.json to include editor rulers at 80 characters. This will display a vertical line in VS Code automatically for developers.
• I’ve refactored tests/testthat/helper-integration-tests-validation.R to reduce duplicate code, making it approximately half as long.
• @Andrea-Havron-NOAA discovered that the tests aren’t estimating recruitment log_devs. A few tests will fail if we estimate log_devs, so I’ve added #TODO tasks in the code to remind us to estimate log_devs once the issue is resolved.

[kellijohnson-NOAA]

@Bai-Li-NOAA great job. Please rebase and merge into dev whenever you see fit.