Dev- tmbad

[msupernaw]

What is the feature?

TMBAd based FIMS
*

How have you implemented the solution?

Changed the template parameter Type by expanding the TMB definitions in def.hpp and incorporating them into the Rcpp interface module.
*

Does the PR impact any other area of the project, maybe another repo?

No
*

[github-actions]

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

• Please use this checklist during your review, checking off items that you have verified are complete!
• For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
• Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
• Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
• PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
• Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

• The PR is requested to be merged into the appropriate branch (typically main)
• The code is well-designed.
• The functionality is good for the users of the code.
• Any User Interface changes are sensible and look good.
• The code isn’t more complex than it needs to be.
• Code coverage remains high, indicating the new code is tested.
• The developer used clear names for everything.
• Comments are clear and useful, and mostly explain why instead of what.
• Code is appropriately documented (doxygen and roxygen).

[codecov]

Codecov Report

Attention: Patch coverage is 52.50545% with 654 lines in your changes missing coverage. Please review.

Project coverage is 68.55%. Comparing base (7cf2c14) to head (04d27b3).
Report is 2 commits behind head on dev.

Files with missing lines	Patch %	Lines
inst/include/interface/rcpp/rcpp_interface.hpp	50.81%	120 Missing ⚠️
...include/interface/rcpp/rcpp_objects/rcpp_fleet.hpp	39.37%	117 Missing ⚠️
...de/interface/rcpp/rcpp_objects/rcpp_population.hpp	35.44%	102 Missing ⚠️
.../interface/rcpp/rcpp_objects/rcpp_distribution.hpp	64.17%	91 Missing ⚠️
...e/interface/rcpp/rcpp_objects/rcpp_selectivity.hpp	57.23%	65 Missing ⚠️
...e/interface/rcpp/rcpp_objects/rcpp_recruitment.hpp	52.42%	49 Missing ⚠️
.../include/interface/rcpp/rcpp_objects/rcpp_data.hpp	61.47%	47 Missing ⚠️
...lude/interface/rcpp/rcpp_objects/rcpp_maturity.hpp	55.55%	40 Missing ⚠️
...nclude/interface/rcpp/rcpp_objects/rcpp_growth.hpp	65.51%	20 Missing ⚠️
...nterface/rcpp/rcpp_objects/rcpp_interface_base.hpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #727      +/-   ##
==========================================
+ Coverage   66.08%   68.55%   +2.46%     
==========================================
  Files          44       44              
  Lines        4662     4719      +57     
  Branches        0      197     +197     
==========================================
+ Hits         3081     3235     +154     
+ Misses       1581     1437     -144     
- Partials        0       47      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.