-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit readme #636
Edit readme #636
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 36 36
Lines 1945 1945
Branches 141 141
=======================================
Hits 1528 1528
Misses 374 374
Partials 43 43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @k-doering-NOAA for putting so much work into organizing this information. I love the move of the developer information to the collaborative workflow. This will help new users a lot I think so that they are not overwhelmed by the amount of information present. I made one comment about the location of the badge but I will leave that up to you.
Great suggestion @kellijohnson-NOAA ! I changed the badge location. Feel free to merge in when https://github.com/NOAA-FIMS/collaborative_workflow/tree/codespaces is also ready to merge in. |
For users and developers, where the information for the latter was moved to the collaborative workflow see NOAA-FIMS/collaborative_workflow#146. A badge for R-universe was placed in the list of all badges! Work was done by @k-doering-NOAA with suggestions by @kellijohnson-NOAA Part of NOAA-FIMS/collaborative_workflow#98
4dded7a
to
0d1acab
Compare
I squashed the commits and will merge into main once the checks are complete. |
What is the feature?
Addresses NOAA-FIMS/collaborative_workflow#98
How have you implemented the solution?
Does the PR impact any other area of the project?
How to test this change
Note the link should work on the readme after NOAA-FIMS/collaborative_workflow#146 is merged in.
Developer pre-PR checklist