-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect densities rebase of PR #619 #624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]> Co-authored-by: Christine Stawitz - NOAA <[email protected]>
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]> Co-authored-by: Christine Stawitz - NOAA <[email protected]> Co-authored-by: Chris Legault <[email protected]> Co-authored-by: KyleShertzer-NOAA <[email protected]>
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]> Co-authored-by: Christine Stawitz - NOAA <[email protected]> Co-authored-by: Chris Legault <[email protected]> Co-authored-by: KyleShertzer-NOAA <[email protected]>
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]>
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
This was referenced Jun 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
The fleet.hpp file was edited to depend on the new density classes. The interface and tests were modified to accomodate changes.
Does the PR impact any other area of the project?
This change does not affect input or output
How to test this change
test_rcpp_tmb_distributions and test-integration-fims-estimation
Developer pre-PR checklist