Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct way of getting tmb output #620

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

k-doering-NOAA
Copy link
Member

What is the feature?

How have you implemented the solution?

Modified one line for the tmb output

Does the PR impact any other area of the project?

case studies should also be modified

How to test this change

I think this has already been tested by @Bai-Li-NOAA, as discussed in #616

Developer pre-PR checklist

  • I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

  • Please use this checklist during your review, checking off items that you have verified are complete!
  • For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
  • Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
  • Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
  • PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
  • Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

  • The PR is requested to be merged into the appropriate branch (typically main)
  • The code is well-designed.
  • The functionality is good for the users of the code.
  • Any User Interface changes are sensible and look good.
  • The code isn’t more complex than it needs to be.
  • Code coverage remains high, indicating the new code is tested.
  • The developer used clear names for everything.
  • Comments are clear and useful, and mostly explain why instead of what.
  • Code is appropriately documented (doxygen and roxygen).

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (e12e353) to head (4a03ce9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          36       36           
  Lines        1945     1945           
  Branches      141      141           
=======================================
  Hits         1528     1528           
  Misses        374      374           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellijohnson-NOAA kellijohnson-NOAA added kind: bug Something isn't working kind: vignette Pertaining to running or editing the vignettes labels Jun 4, 2024
@kellijohnson-NOAA kellijohnson-NOAA added this to the 2 milestone Jun 4, 2024
@Andrea-Havron-NOAA Andrea-Havron-NOAA merged commit 4539fc4 into main Jun 12, 2024
13 checks passed
@Andrea-Havron-NOAA Andrea-Havron-NOAA deleted the update-vignette branch June 12, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working kind: vignette Pertaining to running or editing the vignettes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants