-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor distributions #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]> Co-authored-by: Christine Stawitz - NOAA <[email protected]>
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]> Co-authored-by: Christine Stawitz - NOAA <[email protected]>
Co-authored-by: Matthew-Supernaw-NOAA <[email protected]>
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
cmlegault
reviewed
May 30, 2024
filed new issue to document files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR addesses the following issues:
#170
#573
#581
#585
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project?
The FIMS nll summations will be refactored in the rcpp interface and model.hpp
Output
Itemized nll values are now available
How to test this change
Developer pre-PR checklist