-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create replace_tmpl filter for Jinja2 #33
Create replace_tmpl filter for Jinja2 #33
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33 +/- ##
===========================================
+ Coverage 48.17% 48.23% +0.06%
===========================================
Files 18 18
Lines 1642 1644 +2
Branches 334 335 +1
===========================================
+ Hits 791 793 +2
Misses 791 791
Partials 60 60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Description
This PR adds a filter for Jinja2 rendering called replace_tmpl that takes a string and replaces substrings defined in an input dictionary. The motivation is for when we want to replace multiple substrings in a template in the Global Workflow.
This PR also changes the copy() method that creates task_config in the Task class to deepcopy(), since in at least one case in the Global Workflow, a task_config key points to another dictionary.
Type of change
How Has This Been Tested?
ATM JJOB tests in GDASApp on Orion
Checklist