bugfix: compiler meta-module loads MKL module. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not the job of these modulefiles. They should only load the relevant compiler.
RussTreadon-NOAA
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
These changes look good. They remove the addition of mkl to the module. This should resolve the problem reported in issue #170. Since I don't know the inner workings of building hpc-stack, my approval doesn't carry much weight. Kyle's approval means much more.
kgerheiser
approved these changes
Mar 1, 2021
|
@kgerheiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #170 revealed on Orion that the
hpc-intelmeta-modulefile was also loading theMKLmodule file (in addition to the compiler).On further examination, hpc-intel and hpc-ips modulefiles are trying to load mkl.
Loading MKL is not the job of these meta-modulefiles. They should only load the relevant compiler module
closes #170
This will most likely have an impact on the applications that load this modulefile.
The solution for these applications is to load the
mklmodule afterhpc-intelorhpc-ipsmodulefile is loaded. Unknowingly these applications were loadingmkl, whether they were using it or not, depends on the application. In the case of the GSI, it does use MKL.