Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add esnowanl to enkfgfs cycle #3283

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Add esnowanl to enkfgfs cycle #3283

merged 6 commits into from
Jan 30, 2025

Conversation

TravisElless-NOAA
Copy link
Contributor

Description

Previously the esnowanl task was setup to run only for the enkfgdas cycle. This PR adds the capability for this task to run for the enkfgfs cycle, incorporating the rotating background directory structure used by other enkfgfs tasks.

Resolves #3276

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

3-4 cycles of an ATM with JEDI snow da experiment on Hera.
COMROOT: /scratch2/NCEPDEV/stmp3/Travis.J.Elless/comrot/test_snow_ec
EXPDIR: /scratch1/NCEPDEV/da/Travis.J.Elless/exp/test_snow_ec

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@TravisElless-NOAA
Copy link
Contributor Author

Since I don't have the ability to request additional reviewers, feel free to look at this as well @CoryMartin-NOAA

aerorahul
aerorahul reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor suggestions, but looks ok to me.

jobs/JGLOBAL_SNOWENS_ANALYSIS Outdated Show resolved Hide resolved
jiaruidong2017
jiaruidong2017 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Travis for your efforts.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Jan 30, 2025
aerorahul
aerorahul approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 30, 2025
@emcbot
Copy link

emcbot commented Jan 30, 2025

CI Passed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3283


Experiment C48_ATM_9258e50b Completed 1 Cycles: *SUCCESS* at Thu Jan 30 17:36:43 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_9258e50b Completed 1 Cycles: *SUCCESS* at Thu Jan 30 17:45:03 UTC 2025
Experiment C48mx500_hybAOWCDA_9258e50b Completed 2 Cycles: *SUCCESS* at Thu Jan 30 17:55:18 UTC 2025
Experiment C96C48_hybatmDA_9258e50b Completed 3 Cycles: *SUCCESS* at Thu Jan 30 19:08:53 UTC 2025
Experiment C48_S2SW_9258e50b Completed 1 Cycles: *SUCCESS* at Thu Jan 30 19:22:44 UTC 2025
Experiment C48_S2SWA_gefs_9258e50b Completed 1 Cycles: *SUCCESS* at Thu Jan 30 19:35:22 UTC 2025
Experiment C48mx500_3DVarAOWCDA_9258e50b Completed 2 Cycles: *SUCCESS* at Thu Jan 30 20:22:15 UTC 2025
Experiment C96_atm3DVar_9258e50b Completed 3 Cycles: *SUCCESS* at Thu Jan 30 20:34:12 UTC 2025
Experiment C96C48_hybatmaerosnowDA_9258e50b Completed 3 Cycles: *SUCCESS* at Thu Jan 30 20:34:20 UTC 2025
Experiment C96C48_ufs_hybatmDA_9258e50b Completed 3 Cycles: *SUCCESS* at Thu Jan 30 20:59:01 UTC 2025

@aerorahul aerorahul merged commit 380946c into NOAA-EMC:develop Jan 30, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@jiaruidong2017 jiaruidong2017 jiaruidong2017 approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update snow ensemble analysis to run for enkfgfs cycle
6 participants
@TravisElless-NOAA @emcbot @CoryMartin-NOAA @aerorahul @jiaruidong2017 @WalterKolczynski-NOAA