Add CODEOWNERS #2996
Merged
Add CODEOWNERS #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
requested review from
WalterKolczynski-NOAA,
KateFriedman-NOAA and
DavidHuber-NOAA
There was a problem hiding this comment.
Looks good, thanks for adding this @aerorahul ! Left a few comments.
DavidHuber-NOAA
requested changes
Oct 10, 2024
aerorahul
commented
Oct 11, 2024
Co-authored-by: Kate Friedman <[email protected]> Co-authored-by: David Huber <[email protected]>
DavidHuber-NOAA
approved these changes
Oct 11, 2024
KateFriedman-NOAA
approved these changes
Oct 11, 2024
WalterKolczynski-NOAA
approved these changes
Oct 17, 2024
WalterKolczynski-NOAA
added a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this pull request
Oct 21, 2024
Adds a new checklist item for PRs that confirms any new scripts have been added to the CODEOWNERS file, along with owners. Refs: NOAA-EMC#2996
10 tasks
WalterKolczynski-NOAA
added a commit
to WalterKolczynski-NOAA/global-workflow
that referenced
this pull request
Oct 21, 2024
Adds a new checklist item for PRs that confirms any new scripts have been added to the CODEOWNERS file, along with owners. Refs: NOAA-EMC#2996
DavidHuber-NOAA
pushed a commit
that referenced
this pull request
Oct 21, 2024
# Description Adds a new checklist item for PRs that confirms any new scripts have been added to the CODEOWNERS file, along with owners. Follow-up to #2996 # Type of change - [x] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics <!-- Choose YES or NO from each of the following and delete the other --> - Is this a breaking change (a change in existing functionality)? NO - Does this change require a documentation update? NO - Does this change require an update to any of the following submodules? NO # How has this been tested? N/A # Checklist - [x] Any dependent changes have been merged and published - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have documented my code, including function, input, and output descriptions - [x] My changes generate no new warnings - [x] New and existing tests pass with my changes - [ ] This change is covered by an existing CI test or a new one has been added - [x] I have made corresponding changes to the system documentation if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
CODEOWNERSfile to the repository. global-workflow is a collaborative space where contributions come from a variety of sources. This file will ensure that new development gets reviewed by the appropriate SME.Type of change
Change characteristics
How has this been tested?
There is no code change associated with this PR
Checklist