Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get arch adds an empty archive job to GEFS system #2772

Merged
merged 44 commits into from
Aug 7, 2024
Merged

Feature/get arch adds an empty archive job to GEFS system #2772

merged 44 commits into from
Aug 7, 2024

Conversation

AntonMFernando-NOAA
Copy link
Contributor

@AntonMFernando-NOAA AntonMFernando-NOAA commented Jul 17, 2024 •
edited
Loading

Description

  • This feature added an archive task for GEFS system. This task will run in the service queue with a single processor.
    The task executes with success.
  • Only xml is generated.

Resolves #
Refs #832 #2698
Refs NOAA-EMC/repo#

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Forecast-only on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 17, 2024
View reviewed changes
jobs/rocoto/arch_test.sh Fixed Show resolved Hide resolved
aerorahul
aerorahul requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments that need attention.

workflow/rocoto/gefs_tasks.py Outdated Show resolved Hide resolved
workflow/rocoto/gefs_tasks.py Outdated Show resolved Hide resolved
parm/config/gefs/config.resources Outdated Show resolved Hide resolved
@AntonMFernando-NOAA
Copy link
Contributor Author

AntonMFernando-NOAA commented Aug 6, 2024 •
edited
Loading

@AntonMFernando-NOAA arch_test.sh doesn't appear to have executable permissions.

@WalterKolczynski-NOAA I think I fixed it. However, permission change to a file cannot be added as a commit in git. Please check whether the ci test passes.

@WalterKolczynski-NOAA
Copy link
Contributor

@AntonMFernando-NOAA arch_test.sh doesn't appear to have executable permissions.

@WalterKolczynski-NOAA I think I fixed it. However, permission change to a file cannot be added as a commit in git. Please check whether the ci test passes.

You should be able to.

@DavidHuber-NOAA
Copy link
Contributor

@AntonMFernando-NOAA The mode still is not executable. This worked for me:

> cd jobs/rocoto
> chmod +x arch_test.sh
> git diff arch_test.sh
diff --git a/jobs/rocoto/arch_test.sh b/jobs/rocoto/arch_test.sh
old mode 100644
new mode 100755
> git commit arch_test.sh "Make arch_test.sh executable"

@AntonMFernando-NOAA
Copy link
Contributor Author

@AntonMFernando-NOAA The mode still is not executable. This worked for me:

> cd jobs/rocoto
> chmod +x arch_test.sh
> git diff arch_test.sh
diff --git a/jobs/rocoto/arch_test.sh b/jobs/rocoto/arch_test.sh
old mode 100644
new mode 100755
> git commit arch_test.sh "Make arch_test.sh executable"

@WalterKolczynski-NOAA @DavidHuber-NOAA Good to go now.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Aug 6, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Aug 6, 2024
@emcbot
Copy link

emcbot commented Aug 6, 2024

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2772


Experiment C48_ATM_6fb6cbfc Completed 1 Cycles: *SUCCESS* at Tue Aug  6 15:17:10 CDT 2024
Experiment C96_atm3DVar_6fb6cbfc Completed 3 Cycles: *SUCCESS* at Tue Aug  6 17:31:01 CDT 2024
Experiment C48_S2SW_6fb6cbfc Completed 1 Cycles: *SUCCESS* at Tue Aug  6 17:43:26 CDT 2024
Experiment C96C48_hybatmDA_6fb6cbfc Completed 3 Cycles: *SUCCESS* at Tue Aug  6 17:43:26 CDT 2024
Experiment C48_S2SWA_gefs_6fb6cbfc Completed 1 Cycles: *SUCCESS* at Tue Aug  6 18:07:59 CDT 2024

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress label Aug 7, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 5c2e9b1 into NOAA-EMC:develop Aug 7, 2024
5 checks passed
@AntonMFernando-NOAA AntonMFernando-NOAA deleted the feature/get-arch branch August 7, 2024 18:35
CoryMartin-NOAA pushed a commit to CoryMartin-NOAA/global-workflow that referenced this pull request Aug 7, 2024
@AntonMFernando-NOAA @CoryMartin-NOAA
Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772
efb7804 
)

- This feature added an archive task for GEFS system. This task will run
in the service queue with a single processor.
The task executes with success.
- Only xml is generated.

Refs NOAA-EMC#832
Refs NOAA-EMC#2698
@AntonMFernando-NOAA AntonMFernando-NOAA mentioned this pull request Aug 7, 2024
Merged
7 tasks
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/c768_hera
638a588 
* origin/develop:
  Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792)
  Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799)
  Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772)
  Marine DA updates (NOAA-EMC#2802)
  Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811)
  Bugfix for updating label states in Jenkins (NOAA-EMC#2808)
  Clean-up temporary rundirs - take 2. (NOAA-EMC#2753)
  Change land surface for HR4 (NOAA-EMC#2787)
  Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804)
  Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762)
  Fix erroneous cdump addition (NOAA-EMC#2803)
  Update ocean post-processing triggers (NOAA-EMC#2784)
  Update the gfs_utils repository hash (NOAA-EMC#2801)
  Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791)
  Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727)
  Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/c768_hera
17efba2 
* origin/develop:
  Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792)
  Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799)
  Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772)
  Marine DA updates (NOAA-EMC#2802)
  Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811)
  Bugfix for updating label states in Jenkins (NOAA-EMC#2808)
  Clean-up temporary rundirs - take 2. (NOAA-EMC#2753)
  Change land surface for HR4 (NOAA-EMC#2787)
  Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804)
  Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762)
  Fix erroneous cdump addition (NOAA-EMC#2803)
  Update ocean post-processing triggers (NOAA-EMC#2784)
  Update the gfs_utils repository hash (NOAA-EMC#2801)
  Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791)
  Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727)
  Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)
WalterKolczynski-NOAA pushed a commit that referenced this pull request Sep 7, 2024
@AntonMFernando-NOAA
Add an archive task to GEFS system to archive files locally (#2816)
2816c3b 
- This task is an extension of the empty arch job previously merged. 
- This feature adds an archive task to GEFS system to archive files
locally.
- This feature archives files in ensstat directory. 

Resolves #2698
Refs #832 #2772
@AntonMFernando-NOAA AntonMFernando-NOAA mentioned this pull request Sep 23, 2024
Merged
7 tasks
aerorahul pushed a commit that referenced this pull request Sep 25, 2024
@AntonMFernando-NOAA @DavidHuber-NOAA
Add an archive task to GEFS system to archive files in HPSS (#2895)
7088a91 
- This task is an extension of the arch job previously merged that
archives files in ROTDIR (#2816
AntonMFernando-NOAA@2816c3b)
- This feature adds an archive task to GEFS system to archive files in
HPSSARCH and LOCALARCH.
  Resolves #2698  
  Refs #2816 #2772 #832 
---------

Co-authored-by: David Huber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul aerorahul left review comments

Assignees
No one assigned
Labels
CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AntonMFernando-NOAA @WalterKolczynski-NOAA @emcbot @DavidHuber-NOAA @aerorahul @TerrenceMcGuinness-NOAA