-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminates all machine detection outside detech_machine.sh
#2324
Eliminates all machine detection outside detech_machine.sh
#2324
Conversation
…redundant checks for expected file paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be condensed with case
. See suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @HenryWinterbottom-NOAA !
This was merged with #2239. |
Description
This PR addresses issue #2129. The following is accomplished:
detect_machine.sh
is removed fromush/load_fv3gfs_modules.sh
andufs/load_ufsda_modules.sh
;File system/partition checks are replaced with
${MACHINE_ID}
.Resolves Eliminate all machine detection outside of detect_machine.sh #2129
Type of change
Change characteristics
How has this been tested?
Testing was performed on RDHPCS Hera. A C96 3DVAR experiment was configured and run such that
ush/load_fv3gfs_modules.sh
andufs/load_ufsda_modules.sh
are excercised. The following global-workflow configurtaion was used:./setup_expt.py gfs cycled --app ATM --resdetatmos 96 --comroot ${WORKSPACE}/COMROOT --expdir ${WORKSPACE}/EXPDIR --idate 2021122018 --edate 2021122100 --pslot x005_gwdev_issue_2129 --icsdir /scratch1/NCEPDEV/global/glopara/data/ICSDIR/C96C48/ --nens 0
The following is the Rocoto status for the relevant tasks:
Note that the DA tasks, specifically
gfsanal
andgdasanal
run to completion.Checklist