Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial GSI-based soil analysis capability #2263

Merged
merged 24 commits into from
Mar 18, 2024
Merged

Add initial GSI-based soil analysis capability #2263

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6438626
First pass at adding the GSI-based soil analysis to the workflow.
ClaraDraper-NOAA Jan 16, 2024
f9d0442
Cleaned up print statememts. Runs, adds increments to ensemble only.
ClaraDraper-NOAA Jan 16, 2024
3ab6e71
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Jan 26, 2024
d1434bb
Clean-up, ready for PR.
ClaraDraper-NOAA Jan 26, 2024
7e0e225
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Jan 26, 2024
3f507c0
minor updates for git's spell-check.
ClaraDraper-NOAA Feb 7, 2024
528a511
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Feb 7, 2024
c767ca6
removed work-arounds to avoid call to global_cycle/sfccycle with
ClaraDraper-NOAA Feb 7, 2024
2815023
Updated gsi hash to catch soil analysis updates.
ClaraDraper-NOAA Feb 7, 2024
fb4917a
Turn soil analysis off for default.
ClaraDraper-NOAA Feb 8, 2024
1b0c4a0
Merge branch 'feature/soil_updates' of https://github.com/ClaraDraper…
ClaraDraper-NOAA Feb 8, 2024
9f1d772
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Feb 8, 2024
13026e3
bug fixes.
ClaraDraper-NOAA Feb 13, 2024
734ed4e
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Feb 29, 2024
f77d91f
Update UFS_UTILS hash.
ClaraDraper-NOAA Feb 29, 2024
7168006
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Feb 29, 2024
0dcc2c4
bug fix.
ClaraDraper-NOAA Feb 29, 2024
2129fac
Clean up merge, resolve spelling issues.
ClaraDraper-NOAA Mar 1, 2024
2b6694e
Updated the gsi fix version.
ClaraDraper-NOAA Mar 1, 2024
597b6e0
Merge branch 'develop' into feature/soil_updates
ClaraDraper-NOAA Mar 15, 2024
7e78514
Fixed merge commit in defaults.yaml
ClaraDraper-NOAA Mar 15, 2024
2fb2e73
Merge branch 'develop' into feature/soil_updates
aerorahul Mar 15, 2024
38cf220
Merge branch 'develop' into feature/soil_updates
aerorahul Mar 18, 2024
98660b1
Merge branch 'develop' into feature/soil_updates
aerorahul Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions parm/config/gfs/config.anal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ export OZINFO=${FIXgsi}/global_ozinfo.txt
export SATINFO=${FIXgsi}/global_satinfo.txt
export OBERROR=${FIXgsi}/prepobs_errtable.global

if [[ ${GSI_SOILANAL} = ".true." ]]; then
export hofx_2m_sfcfile=".true."
export reducedgrid=".false." # not possible for sfc analysis, Jeff Whitaker says it's not useful anyway
export paranc=".false." # temporary until sfc io coded for parance (PR being prepared by T. Gichamo)
export CONVINFO=${FIXgsi}/global_convinfo_2mObs.txt
export ANAVINFO=${FIXgsi}/global_anavinfo_soilanal.l127.txt
fi

# Use experimental dumps in EMC GFS v16 parallels
if [[ ${RUN_ENVIR} == "emc" ]]; then
Expand Down
2 changes: 2 additions & 0 deletions parm/config/gfs/config.base.emc.dyn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,8 @@ fi

if [[ "${DOIAU_ENKF}" = "NO" ]]; then export IAUFHRS_ENKF="6"; fi

export GSI_SOILANAL="NO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a templated variable and set it to NO as the default?
That way, we can set this to YES in one of the existing tests and ensure this capability is tested regularly.
The test this could piggy back off on is C96C48_hybatmDA.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rahul - I'm not familiar with the templating, but followed through the example for DOIAU. Is this all I need to do?

In config.base.emc.dyn change the line highlighted above to:

export GSI_SOILANAL=@GSI_SOILANAL@

Then in parm/config/gfs/yaml/defaults.yaml I set the default to NO.

For the test, should I add GSI_SOILANAL=YES to C96C48_hybatmDA.yaml, or create a new test based on that one?


# turned on nsst in anal and/or fcst steps, and turn off rtgsst
export DONST="YES"
if [[ ${DONST} = "YES" ]]; then export FNTSFA=" "; fi
Expand Down
7 changes: 6 additions & 1 deletion parm/config/gfs/config.esfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,13 @@ echo "BEGIN: config.esfc"
# Set DOSFCANL_ENKF=NO to prevent creation of sfcanl at
# center of analysis window.

if [ $DOIAU_ENKF = "YES" ]; then
if [[ ${DOIAU_ENKF} = "YES" ]]; then
export DOSFCANL_ENKF="NO"
fi

if [[ ${GSI_SOILANAL} = "YES" ]]; then
export DO_LNDINC=".true."
export LND_SOI_FILE="lnd_incr"
fi

echo "END: config.esfc"
13 changes: 10 additions & 3 deletions scripts/exgdas_enkf_sfc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ pwd=$(pwd)

# Base variables
DONST=${DONST:-"NO"}
GSI_SOILANAL=${GSI_SOILANAL:-"NO"}
DOSFCANL_ENKF=${DOSFCANL_ENKF:-"YES"}
export CASE=${CASE:-384}
ntiles=${ntiles:-6}
Expand Down Expand Up @@ -63,7 +64,6 @@ export DELTSFC=${DELTSFC:-6}
APRUN_ESFC=${APRUN_ESFC:-${APRUN:-""}}
NTHREADS_ESFC=${NTHREADS_ESFC:-${NTHREADS:-1}}


################################################################################
# Preprocessing
mkdata=NO
Expand Down Expand Up @@ -144,8 +144,10 @@ if [ $DOIAU = "YES" ]; then
MEMDIR=${memchar} RUN="enkfgdas" YMD=${gPDY} HH=${gcyc} generate_com \
COM_ATMOS_RESTART_MEM_PREV:COM_ATMOS_RESTART_TMPL

[[ ${TILE_NUM} -eq 1 ]] && mkdir -p "${COM_ATMOS_RESTART_MEM}"
MEMDIR=${memchar} YMD=${PDY} HH=${cyc} generate_com \
COM_ATMOS_ANALYSIS_MEM:COM_ATMOS_ANALYSIS_TMPL

[[ ${TILE_NUM} -eq 1 ]] && mkdir -p "${COM_ATMOS_RESTART_MEM}"
${NCP} "${COM_ATMOS_RESTART_MEM_PREV}/${bPDY}.${bcyc}0000.sfc_data.tile${n}.nc" \
"${COM_ATMOS_RESTART_MEM}/${bPDY}.${bcyc}0000.sfcanl_data.tile${n}.nc"
${NLN} "${COM_ATMOS_RESTART_MEM_PREV}/${bPDY}.${bcyc}0000.sfc_data.tile${n}.nc" \
Expand All @@ -155,7 +157,12 @@ if [ $DOIAU = "YES" ]; then
${NLN} "${FIXorog}/${CASE}/${CASE}_grid.tile${n}.nc" "${DATA}/fngrid.${cmem}"
${NLN} "${FIXorog}/${CASE}/${CASE}.mx${OCNRES}_oro_data.tile${n}.nc" "${DATA}/fnorog.${cmem}"

done
if [[ ${GSI_SOILANAL} = "YES" ]]; then
FHR=6
${NLN} "${COM_ATMOS_ANALYSIS_MEM}/${APREFIX_ENS}sfci00${FHR}.nc" \
WalterKolczynski-NOAA marked this conversation as resolved.
Show resolved Hide resolved
"${DATA}/lnd_incr.${cmem}"
fi
done # ensembles

CDATE="${PDY}${cyc}" ${CYCLESH}
export err=$?; err_chk
Expand Down
9 changes: 9 additions & 0 deletions scripts/exgdas_enkf_update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ else
DO_CALC_INCREMENT=${DO_CALC_INCREMENT:-"NO"}
fi
INCREMENTS_TO_ZERO=${INCREMENTS_TO_ZERO:-"'NONE'"}
GSI_SOILANAL=${GSI_SOILANAL:-"NO"}

################################################################################

Expand Down Expand Up @@ -203,6 +204,10 @@ for imem in $(seq 1 $NMEM_ENS); do
for FHR in $nfhrs; do
${NLN} "${COM_ATMOS_HISTORY_MEM_PREV}/${GPREFIX}atmf00${FHR}${ENKF_SUFFIX}.nc" \
"sfg_${PDY}${cyc}_fhr0${FHR}_${memchar}"
if [ $GSI_SOILANAL = "YES" ]; then
${NLN} "${COM_ATMOS_HISTORY_MEM_PREV}/${GPREFIX}sfcf00${FHR}${ENKF_SUFFIX}.nc" \
"bfg_${PDY}${cyc}_fhr0${FHR}_${memchar}"
WalterKolczynski-NOAA marked this conversation as resolved.
Show resolved Hide resolved
fi
if [ $cnvw_option = ".true." ]; then
${NLN} "${COM_ATMOS_HISTORY_MEM_PREV}/${GPREFIX}sfcf00${FHR}.nc" \
"sfgsfc_${PDY}${cyc}_fhr0${FHR}_${memchar}"
Expand All @@ -224,6 +229,10 @@ for imem in $(seq 1 $NMEM_ENS); do
"incr_${PDY}${cyc}_fhr0${FHR}_${memchar}"
fi
fi
if [ $GSI_SOILANAL = "YES" ]; then
${NLN} "${COM_ATMOS_ANALYSIS_MEM}/${APREFIX}sfci00${FHR}.nc" \
"sfcincr_${PDY}${cyc}_fhr0${FHR}_${memchar}"
fi
done
done

Expand Down
5 changes: 4 additions & 1 deletion scripts/exglobal_atmos_analysis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ SENDDBN=${SENDDBN:-"NO"}
RUN_GETGES=${RUN_GETGES:-"NO"}
GETGESSH=${GETGESSH:-"getges.sh"}
export gesenvir=${gesenvir:-${envir}}

export hofx_2m_sfcfile=${hofx_2m_sfcfile:-".false."}

# Observations
OPREFIX=${OPREFIX:-""}
Expand Down Expand Up @@ -296,6 +298,7 @@ RADCLOUDINFO=${RADCLOUDINFO:-${FIXgsi}/cloudy_radiance_info.txt}
ATMSFILTER=${ATMSFILTER:-${FIXgsi}/atms_beamwidth.txt}
ANAVINFO=${ANAVINFO:-${FIXgsi}/global_anavinfo.l${LEVS}.txt}
CONVINFO=${CONVINFO:-${FIXgsi}/global_convinfo.txt}

vqcdat=${vqcdat:-${FIXgsi}/vqctp001.dat}
INSITUINFO=${INSITUINFO:-${FIXgsi}/global_insituinfo.txt}
OZINFO=${OZINFO:-${FIXgsi}/global_ozinfo.txt}
Expand Down Expand Up @@ -748,6 +751,7 @@ cat > gsiparm.anl << EOF
/
&OBS_INPUT
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=100.0,dmesh(4)=50.0,time_window_max=3.0,
hofx_2m_sfcfile=${hofx_2m_sfcfile},
${OBSINPUT}
/
OBS_INPUT::
Expand Down Expand Up @@ -909,7 +913,6 @@ ${NCP} ${GSIEXEC} ${DATA}
${APRUN_GSI} ${DATA}/$(basename ${GSIEXEC}) 1>&1 2>&2
export err=$?; err_chk


##############################################################
# If full analysis field written, calculate analysis increment
# here before releasing FV3 forecast
Expand Down
2 changes: 1 addition & 1 deletion sorc/gsi_enkf.fd
Open in desktop
Submodule gsi_enkf.fd updated 143 files
Loading