Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all machine-specific options to workflow/hosts files #2942

Closed
DavidHuber-NOAA opened this issue Sep 19, 2024 · 0 comments · Fixed by #3053
Closed

Move all machine-specific options to workflow/hosts files #2942

DavidHuber-NOAA opened this issue Sep 19, 2024 · 0 comments · Fixed by #3053
Assignees
Labels
feature New feature or request

Comments

@DavidHuber-NOAA
Copy link
Contributor

What new functionality do you need?

Any jobs that need to be skipped on a specific machine should be specified in the workflow/hosts/.yaml file and appropriate templates added to config.base. As-is, options are hard coded into config.base, e.g.

# The tracker, genesis, and METplus jobs are not supported on CSPs yet
# TODO: we should place these in workflow/hosts/awspw.yaml as part of AWS/AZURE setup, not for general.
if [[ "${machine}" =~ "PW" ]]; then
export DO_TRACKER="NO"
export DO_GENESIS="NO"
export DO_METP="NO"
export DO_WAVE="NO"
fi

Instead, these options should be added to each host file. This will also necessitate removing these options from the CI defaults yaml file:

DO_TRACKER: "YES"
DO_GENESIS: "YES"
DO_GENESIS_FSU: "NO"
DO_METP: "YES"

What are the requirements for the new functionality?

All systems configure and run only the jobs that they need to run without hard coding anything into J-Jobs, scripts, or config files.

Acceptance Criteria

There are no machine-specific options in config.base and CI passes on all affected platforms.

Suggest a solution (optional)

No response

@DavidHuber-NOAA DavidHuber-NOAA added feature New feature or request triage Issues that are triage labels Sep 19, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Sep 27, 2024
@DavidHuber-NOAA DavidHuber-NOAA self-assigned this Oct 7, 2024
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Nov 22, 2024
)

This moves all machine-specific options to the workflow/hosts files from
the config.* files.

This also turns HPSS archiving on for WCOSS2 by default.
This turns OFF UFS DA tests on WCOSS2.

Resolves NOAA-EMC#2942
Resolves NOAA-EMC#3087

---------

Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants