Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up layout specification when running UFSDA ATM var and ensda apps #1936

Closed
RussTreadon-NOAA opened this issue Oct 17, 2023 · 3 comments · Fixed by #1945
Closed

clean up layout specification when running UFSDA ATM var and ensda apps #1936

RussTreadon-NOAA opened this issue Oct 17, 2023 · 3 comments · Fixed by #1945
Assignees
Labels
feature New feature or request

Comments

@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Oct 17, 2023

What new functionality do you need?

Two items related to layout variables for UFSDA ATM variational and local ensemble apps are addressed in this issue.

First, UFSDA ATM variational and local ensemble apps do not specify layout_x and layout_y in the same was as UFSDA Aerosol and Land DA. A consistent approach should be used across all UFSDA apps. This issue documents the moving of layout_x and layout_y from config.atmanl and config.atmensanl to defaults.yaml. This brings all four UFSDA apps into consistency with regards to how these variables are set.

Second, the UFSDA ATM variational app has the option to use the GSI static-B. Processing of the GSI static-B is a function of variables layout_gsi_b and layout_gsib_y. Currently these variables are hardwired in GDASApp parm files. GDASApp issue #680 removes this restriction by adding variables layout_gsib_x and layout_gsib_y. This g-w issue add variables layout_gsib_x and layout_gsib_y to atmanlrun section of parm/config/gfs/config.resources. This allows users to more easily control the layout used to process the GSI static-B.

What are the requirements for the new functionality?

  1. The layout for UFSDA ATM variational and local ensemble apps are consistent with the approach used for UFSDA aerosol and land apps.
  2. The layout for GSI static-B is set in the g-w configuration along with changes from 1.

Acceptance Criteria

UFSDA ATM variational and local ensemble apps correctly run with layout configurations set in g-w config files.

Suggest a solution (optional)

No response

@RussTreadon-NOAA
Copy link
Contributor Author

Work for this development will be done in RussTreadon-NOAA/global-workflow:feature/gsibec.

RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Oct 17, 2023
RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Oct 18, 2023
@RussTreadon-NOAA
Copy link
Contributor Author

config.atmanl and config.atmensanl set layout_x and layout_y. config.resources also sets layout_x and layout_y for jobs atmanlrun and atmensanl. This is dangerous. We should not set the same variables in two locations.

config.aeroanl and config.landanl do not set layout_x and layout_y. Both allow config.resources to set these layout variables. This approach is preferable.

Another nice feature of config.aeroanl and config.landanl is that both set io_layout_x and io_layout_y via templated variables defined in yaml/defaults.yaml. Currently, config.atmanl and config.atmensanl hardwire io_layout_x and io_layout_y to fixed values. It's best to have a consistent approach for UFSDA apps.

Update config.atmanl, config.atmensanl, and config.resources to be consistent with aero and land approaches. Done at 01bbfee.

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Oct 19, 2023
@RussTreadon-NOAA RussTreadon-NOAA changed the title set layout for reading GSI static-B when running UFSDA ATM variational app clean up layout specification when running UFSDA ATM var and ensda apps Oct 20, 2023
RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Oct 20, 2023
RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Oct 21, 2023
@RussTreadon-NOAA
Copy link
Contributor Author

While atmanlrun uses {layout_x, layout_y} and, optionally, {layout_gsib_x, layout_gsib_y}, the run job accesses these variables via the yaml file created by atmanlinit. Setting the layout variables only in the atmanlrun section of config.resources is not correct. Both sets of layout variables need to be defined in atmanlinit.

We also need {layout_x, layout_y} in atmanlrun. These variables are used to define npe_atmanlrun and npe_atmanlrun_gfs.

The above changes to config.resources were committed at ad5e723.

RussTreadon-NOAA added a commit to RussTreadon-NOAA/global-workflow that referenced this issue Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants