Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of convective cloud condensate in prog closure for HR2 #639

Merged
merged 10 commits into from
Apr 6, 2023

Conversation

lisa-bengtsson
Copy link
Contributor

This PR updates the prognostic closure in samfdeepcnv.f and samfshalcnv.f for HR2:

  1. correction (bug-fix) of convective cloud condensate passed to progsigma_calc.F90 routine
  2. Update to only consider positive buoyant levels in integral (to make it general if a convection scheme can have negative buoyant levels between cloud base and cloud top)
  3. Update to make the prognostic closure general to pass in q-tendency due to turbulence from any PBL scheme.
  4. Move out computation of q-tendency due to dynamics from progsigma_clac.F90 (to samfshalcnv and samfdeepcnv) because other convection schemes compute this term in a pre/post step. I will update samf* routines to use pre/post convection in the future.

@grantfirl
Copy link
Collaborator

@lisa-bengtsson ufs-community/ccpp-physics#57 was merged. This is ready to revert the changes in .gitmodules (which it looks like you already did) and update the ccpp/physics submodule pointer to the latest commit (after the ccpp-physics PR was merged) in ufs/dev.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Apr 6, 2023

@lisa-bengtsson ccpp pr was merged . can you update ccpp submodule pointer? correct hash is ufs-community/ccpp-physics@57c444f

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Apr 6, 2023

@lisa-bengtsson branch is pointing to ccpp 03acf73 hash. correct one is 57c444f

@jkbk2004 jkbk2004 self-requested a review April 6, 2023 16:57
@lisa-bengtsson
Copy link
Contributor Author

@jkbk2004 Now it looks to be correct. Thank you.

@lisa-bengtsson
Copy link
Contributor Author

@jkbk2004 is this merged?

@jkbk2004 jkbk2004 merged commit decb0b9 into NOAA-EMC:develop Apr 6, 2023
@grantfirl grantfirl mentioned this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants