Update Regression Test to include gfsv17 prototypes that are after prototype 8, and turn on prognostic closure #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lisa-bengtsson can you update ccpp submodule pointer and revert the gitmodules branch? |
|
@jkbk2004 I updated the pointer in .gimodules |
|
@lisa-bengtsson correct ccpp hash is ufs-community/ccpp-physics@befc336. Can you update the ccpp submodule poiinter? |
|
@jkbk2004 how can I see the submodule hashes ? |
JessicaMeixner-NOAA
approved these changes
Dec 5, 2022
|
Ok, thank you for confirming. |
|
@DusanJovic-NOAA @BrianCurtis-NOAA you can go ahead to approve this pr. |
DusanJovic-NOAA
approved these changes
Dec 5, 2022
BrianCurtis-NOAA
approved these changes
Dec 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These PR’s in ufs-weather-model, fv3atm and ccpp/physics does the following:
Creates a set of _gfsv17 RT’s to reflect tests that are beyond prototype 8 targeted for GFSv17
Activates prognostic closure by setting namelist progsigma = true in *gfsv17 and pointing to new field_table in the RT’s
Addresses additional parametric tuning in progclosure_calc.F90
Adds a new gfsv17 field_table and diag_table
Issue(s) addressed
ufs-community/ufs-weather-model#1477
Testing
New ufs-weather-model RT tests have been carried out on Hera
Dependencies
ufs-community/ufs-weather-model#1480
ufs-community/ccpp-physics#18