-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new SDF named FV3_WoFS_v0 for SRW_v2.1 release #594
Conversation
@ChunxiZhang-NOAA Thank you for this PR. Should a regression test be added so we can make sure this publicly released and supported suite does not break going forward? |
@ligiabernardet Yes, the regression test is added here. |
@MicroTed Could you please review this PR. |
@ChunxiZhang-NOAA As soon as you point the ccpp/physics pointer to ufs-community/ccpp-physics#14 in this PR, I'll get rid of the drafts in fv3atm/ufs-weather-model that I created for the docs update. |
@MicroTed I noticed that GFS_suite_interstitial_4 is not in suite_FV3_RRFS_v1nssl.xml and suite_FV3_WoFS_v0.xml. There is part of code for "imp_physics == imp_physics_nssl" in GFS_suite_interstitial_4.F90. Do you know why it is not included in the suite definition file? |
@ChunxiZhang-NOAA It is not needed. I asked @MicroTed the same question and here was his response (copied from email): "GFS_suite_interstitial_4 only does something specifically for NSSL-2mom if there are droplets or ice crystals injected by a convection parameterization. (Creates number concentration for the new particles.)" Since there is no convection in this suite, there is no reason to call this interstitial in the WoFS suite. |
Yes, thanks for chiming in, @grantfirl -- If there is no parameterized convection, then the interstitial subroutines do nothing. |
@grantfirl @MicroTed Thank you! |
@grantfirl I pointed the ccpp-physics pointer to Man's branch. Saw you have closed those draft PRs, haha. |
…e (CCPP_typedefs.F90)
@DusanJovic-NOAA @RatkoVasic-NOAA all tests are done on ufs-wm pr 1460. This pr can be merged once @ChunxiZhang-NOAA revert gitmodules. |
…cs ufs/dev branch
Description
This PR includes two main tasks:
Testing
The description of the regression test is provided in the ufs-weather-model level PR#1460.
Dependencies
waiting on ufs-community/ccpp-physics/pull/#14