Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline post for multiple domains #570

Merged
merged 13 commits into from
Sep 1, 2022

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Aug 2, 2022

Description

Provide a detailed description of what this PR does.
This PR updates inline post to support multiple domains (nests).

What bug does it fix, or what feature does it add? Multiple domains in inline post
Is a change of answers expected from this PR? Yes.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? Regression test on Hera
What compilers / HPCs was it tested with? Hera/Intel
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes. Hera.

  • Will the code updates change regression test baseline? Yes. two HAFS tests will run inline post.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? Yes.
If so add the "waiting for other repos" label and list the upstream PRs

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 1, 2022

RT test runs all passed for the upstream PR 1362. Can we have final approvals and start merging this pr?

@SMoorthi-emc
Copy link
Contributor

SMoorthi-emc commented Sep 1, 2022 via email

@DusanJovic-NOAA
Copy link
Collaborator Author

Why not set default to YES for inline post? I hope most people want to use inline post. Moorthi

I agree, it should be ON by default. I think initially, when inline post was added, it was running only on few platforms, so the default was made to be OFF, and it was turned ON on those platforms that supported it. At this moment I believe inline post runs on most platforms.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 1, 2022

@BrianCurtis-NOAA @DeniseWorthen we need one more approval from cm group.

@jkbk2004 jkbk2004 merged commit 0ddec69 into NOAA-EMC:develop Sep 1, 2022
@DusanJovic-NOAA DusanJovic-NOAA deleted the mdpost branch September 1, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable inline post on multiple atm output grids in HAFS application
6 participants