Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency fix: exponentiation instead of multiplication caused bad 2m temperatures #552

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Jun 10, 2022

Description

Emergency bugfix for the MYNN surface layer scheme:

 TH1D(I)=T1D(I)**(100000./P1D(I))**ROVCP !(Theta, K)

The first ** should be a *

 TH1D(I)=T1D(I)*(100000./P1D(I))**ROVCP !(Theta, K)

Issue(s) addressed

NCAR/ccpp-physics#941
ufs-community/ufs-weather-model#1260

Testing

How were these changes tested? Full regression test suite and more in NOAA-GSL fork
What compilers / HPCs was it tested with? hera.intel, hera.gnu, jet.intel
Have the ufs-weather-model regression test been run? On what platform? hera.intel, hera.gnu, jet.intel

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. Yes, anything that uses module_sf_mynn

Dependencies

NCAR/ccpp-physics#940

@jkbk2004 jkbk2004 merged commit e2d12a8 into NOAA-EMC:develop Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants