Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production/GFS.v16: fix the frozen precip density issue #546

Merged
merged 2 commits into from
Jun 13, 2022
Merged

production/GFS.v16: fix the frozen precip density issue #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8261064
fix the frozen precip density issue
HelinWei-NOAA Apr 18, 2022
e15e209
Merge pull request #13 from NOAA-EMC/production/GFS.v16
HelinWei-NOAA Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gfsphysics/GFS_layer/GFS_physics_driver.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,6 +1822,7 @@ subroutine GFS_physics_driver &
Radtend%sfalb, flag_iter, flag_guess, Model%lheatstrg, &
Model%isot, Model%ivegsrc, &
bexp1d, xlai1d, vegf1d, Model%pertvegf, &
Sfcprop%dgraupelprv, Sfcprop%diceprv, &
! --- input/output:
weasd3(:,1), snowd3(:,1), tsfc3(:,1), tprcp3(:,1), &
Sfcprop%srflag, smsoil, stsoil, slsoil, Sfcprop%canopy, &
Expand Down Expand Up @@ -5246,7 +5247,7 @@ subroutine GFS_physics_driver &

! --- get the amount of different precip type for Noah MP
! --- convert from m/dtp to mm/s
if (Model%lsm==Model%lsm_noahmp) then
if (Model%lsm==Model%lsm_noahmp .or. Model%lsm==Model%lsm_noah) then
if (Model%imp_physics == Model%imp_physics_mg .or. &
Model%imp_physics == Model%imp_physics_gfdl) then
!GJF: Should all precipitation rates have the same denominator below?
Expand All @@ -5266,7 +5267,7 @@ subroutine GFS_physics_driver &
Sfcprop%dgraupelprv(:) = 0.0
Sfcprop%diceprv(:) = 0.0
endif
end if ! if (Model%lsm == Model%lsm_noahmp)
end if ! if (Model%lsm == Model%lsm_noahmp .or. Model%lsm==Model%lsm_noah)

if (Model%cal_pre) then ! hchuang: add dominant precipitation type algorithm
!
Expand Down
4 changes: 4 additions & 0 deletions gfsphysics/GFS_layer/GFS_typedefs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2308,6 +2308,10 @@ subroutine sfcprop_create (Sfcprop, IM, Model)
Sfcprop%smoiseq = clear_val
Sfcprop%zsnsoxy = clear_val

endif

if (Model%lsm == Model%lsm_noahmp .or. Model%lsm == Model%lsm_noah) then

allocate(Sfcprop%draincprv (IM))
allocate(Sfcprop%drainncprv (IM))
allocate(Sfcprop%diceprv (IM))
Expand Down
11 changes: 11 additions & 0 deletions gfsphysics/physics/sfc_drv.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ subroutine sfc_drv &
& shdmin, shdmax, snoalb, sfalb, flag_iter, flag_guess, &
& lheatstrg, isot, ivegsrc, &
& bexppert, xlaipert, vegfpert,pertvegf, & ! sfc perts, mgehne
& graupel_mp, ice_mp, &
! --- in/outs:
& weasd, snwdph, tskin, tprcp, srflag, smc, stc, slc, &
& canopy, trans, tsurf, zorl, &
Expand Down Expand Up @@ -190,6 +191,9 @@ subroutine sfc_drv &
& snoalb, sfalb, zf,
& bexppert, xlaipert, vegfpert

real (kind=kind_phys), dimension(im), intent(in) :: &
& graupel_mp, ice_mp &

real (kind=kind_phys), intent(in) :: delt

logical, dimension(im), intent(in) :: flag_iter, flag_guess, land
Expand Down Expand Up @@ -231,6 +235,8 @@ subroutine sfc_drv &
& xlai, zlvl, swdn, tem, z0, bexpp, xlaip, vegfp, &
& mv,sv,alphav,betav,vegftmp

real (kind=kind_phys) :: graupel_prcp, ice_prcp

integer :: couple, ice, nsoil, nroot, slope, stype, vtype
integer :: i, k, iflag

Expand Down Expand Up @@ -320,6 +326,10 @@ subroutine sfc_drv &
! ffrozp = 0.0
! endif
ffrozp = srflag(i)

graupel_prcp = graupel_mp(i) ! grpl part of MP precip [mm/s]
ice_prcp = ice_mp(i) ! ice part of MP precip [mm/s]

ice = 0

zlvl = zf(i)
Expand Down Expand Up @@ -451,6 +461,7 @@ subroutine sfc_drv &
& vtype, stype, slope, shdmin1d, alb, snoalb1d, &
& bexpp, xlaip, & ! sfc-perts, mgehne
& lheatstrg, &
& graupel_prcp, ice_prcp, &
! --- input/outputs:
& tbot, cmc, tsea, stsoil, smsoil, slsoil, sneqv, chx, cmx, &
& z0, &
Expand Down
20 changes: 20 additions & 0 deletions gfsphysics/physics/sflx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ subroutine sflx &
& vegtyp, soiltyp, slopetyp, shdmin, alb, snoalb, &
& bexpp, xlaip, & ! sfc-perts, mgehne
& lheatstrg, &
& graupel_prcp, ice_prcp, &
! --- input/outputs:
& tbot, cmc, t1, stc, smc, sh2o, sneqv, ch, cm,z0, &
! --- outputs:
Expand Down Expand Up @@ -206,6 +207,8 @@ subroutine sflx &

logical, intent(in) :: lheatstrg

real (kind=kind_phys), intent(in) :: ice_prcp, graupel_prcp

! --- input/outputs:
real (kind=kind_phys), intent(inout) :: tbot, cmc, t1, sneqv, &
& stc(nsoil), smc(nsoil), sh2o(nsoil), ch, cm
Expand Down Expand Up @@ -2707,6 +2710,7 @@ subroutine snow_new

! --- locals:
real(kind=kind_phys) :: dsnew, snowhc, hnewc, newsnc, tempc
real(kind=kind_phys) :: dgnew, dinew, dfnew

!
!===> ... begin here
Expand All @@ -2728,6 +2732,22 @@ subroutine snow_new
dsnew = 0.05 + 0.0017*(tempc + 15.0)**1.5
endif

dgnew = 1000.0 / max(2.,(3.5*tanh((274.15-sfctmp)*0.3333)))
dgnew = min(500.0, dgnew) ! kg/m3 (from RUC model)
dgnew = dgnew / 1000.0 ! convert units to [m-liq/m-snow]
! dinew = 250.0 / 1000.0 ! assume cloud ice is 250 kg/m3
dfnew = 500.0 / 1000.0 ! assume freezing rain is 500 kg/m3

if (snowng) then
dsnew = (dsnew*(prcp * ffrozp - graupel_prcp ) +
& dgnew*graupel_prcp)/(prcp * ffrozp)
! dsnew = (dsnew*(prcp * ffrozp - graupel_prcp - ice_prcp) +
! & dgnew*graupel_prcp + dinew*ice_prcp)/(prcp * ffrozp)
endif
if (frzgra) then
dsnew = dfnew
endif

! --- ... adjustment of snow density depending on new snowfall

hnewc = newsnc / dsnew
Expand Down