-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Stochastically Perturbed Parameterizations (SPP) in FV3 and add the FV3_RRFS_v1alpha SDF. #454
Merged
junwang-noaa
merged 85 commits into
NOAA-EMC:develop
from
JeffBeck-NOAA:feature/stoch_spp
Feb 23, 2022
Merged
Changes from 83 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
f9303aa
submodule pointer for ccpp-physics
aedc3d4
update submodules
9165823
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
68368e2
update submodule atmos_cubed_sphere
6fb3045
Add SPP option to several physics parameterizations
1b9a07f
bug fixes
4879a4e
Merge branch 'develop' of https://github.com/noaa-emc/fv3atm into fea…
75e1199
update rte/rrtmgp
9a7d80f
update submodule pointer
cbb9503
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
a66ff66
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
987cbc9
Update pointer for ccpp-physics to JeffBeck-NOAA fork
JeffBeck-NOAA 8436d56
Update submodule pointers
JeffBeck-NOAA 5798d15
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA cf74133
Requested modifications from code review.
JeffBeck-NOAA 0263a28
Remove "flipped" entries for stochastic physics.
JeffBeck-NOAA eee2d37
Remove print statements.
JeffBeck-NOAA 63250e3
Change "v" to "n" to conform with integer variables.
JeffBeck-NOAA 1fc7543
Remove variable duplications in the Intdiag type.
JeffBeck-NOAA 045d7c8
Remove references to Intdiag variables.
JeffBeck-NOAA 6550555
Add the FV3_RRFS_v1alpha SDF back into fv3atm.
JeffBeck-NOAA 679714e
Update stochastic_physics/stochastic_physics_wrapper.F90
JeffBeck-NOAA f3d9e6f
Update stochastic_physics/stochastic_physics_wrapper.F90
JeffBeck-NOAA 9ec20cb
Update ccpp/driver/GFS_diagnostics.F90
JeffBeck-NOAA 5fe5c35
Update ccpp/driver/GFS_diagnostics.F90
JeffBeck-NOAA 543efe1
Update ccpp/driver/GFS_diagnostics.F90
JeffBeck-NOAA d1c3640
Update ccpp/driver/GFS_diagnostics.F90
JeffBeck-NOAA 5029e1f
Update ccpp/driver/GFS_diagnostics.F90
JeffBeck-NOAA 1d2f6f2
Requested changes during code review.
JeffBeck-NOAA eb7b507
Merge branch 'feature/stoch_spp' of https://github.com/JeffBeck-NOAA/…
JeffBeck-NOAA 40a5a42
Update submodule pointers
JeffBeck-NOAA 2ce7a38
Update UPP submodule pointer
JeffBeck-NOAA 59c9bf2
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA eedae98
Update ccpp-physics submodule pointer
JeffBeck-NOAA 36bfa9d
Set upp submodule pointer to specific hash in fv3atm.
JeffBeck-NOAA 518d6a3
Set UPP submodule pointer to specific hash in fv3atm.
JeffBeck-NOAA dd0e231
Merge branch 'feature/stoch_spp' of https://github.com/JeffBeck-NOAA/…
JeffBeck-NOAA 3e04637
Update submodule pointer for ccpp/physics
JeffBeck-NOAA 654c192
Changes for PR modifcation requests
JeffBeck-NOAA 4d6597c
Test changes after PR review modifications
JeffBeck-NOAA 0358570
Allocate spp_wts_* arrays in GFS_typedefs.F90 and not in the stochast…
JeffBeck-NOAA 33f9997
Changes for PR modification requests
JeffBeck-NOAA 3f85580
Test changes after PR review modifications
JeffBeck-NOAA a619064
Allocate spp_wts_* arrays in GFS_typedefs.F90 and not in the stochast…
JeffBeck-NOAA 1a5c99d
Merge branch 'feature/stoch_spp_part2' of https://github.com/JeffBeck…
JeffBeck-NOAA 906c341
Update pointers for ccpp/physics and ccpp/framework
JeffBeck-NOAA 22bd1e7
Update ccpp/physics pointer
JeffBeck-NOAA e4f8b63
Change pointers and .gitmodule feature branch for ccpp-physics
JeffBeck-NOAA 9551574
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA bf11e2c
Update pointer for ccpp/physics
JeffBeck-NOAA 6bbe037
Update UPP pointer
JeffBeck-NOAA ffbb736
Update UPP pointer
JeffBeck-NOAA 2b0d373
Don't limit the size of spp_var_list
JeffBeck-NOAA d977250
Update pointer for ccpp/physics
JeffBeck-NOAA 0e300e2
Update pointer for ccpp/physics
JeffBeck-NOAA 3575581
Update ccpp/physics pointer
JeffBeck-NOAA b50c0ce
Fix spp_var/prt_list in GFS_typedefs.F90
JeffBeck-NOAA 2fda378
Make SPP variables pointers in GFS_typedefs.F90
JeffBeck-NOAA a030e43
Updates to standard names and units
JeffBeck-NOAA 75c0c20
Update ccpp/physics pointer
JeffBeck-NOAA bd13650
Change spp_prt_list to a variable unit
JeffBeck-NOAA 1ddbf09
Update do_spp metadata
JeffBeck-NOAA 15ede90
Update ccpp/physics pointer
JeffBeck-NOAA ea02e0e
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA 4efb22f
Update ccpp/physics pointer
JeffBeck-NOAA cd453a3
Update ccpp/physics pointer
JeffBeck-NOAA 47f8481
Update ccpp/physics pointer
JeffBeck-NOAA 6360ccd
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA 169eeb6
Update ccpp/physics pointer
JeffBeck-NOAA 3128a48
Update ccpp/physics pointer
JeffBeck-NOAA 4108ae2
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA 2ccc067
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA bc896a3
Update ccpp/physics pointer
JeffBeck-NOAA c3c4ca9
Update units for spp_prt_list.
JeffBeck-NOAA 139049f
Update do_spp standard name.
JeffBeck-NOAA 587adba
Update do_spp standard name
JeffBeck-NOAA 51fad10
Revert erroneous do_sppt standard name change.
JeffBeck-NOAA f12ceea
Change all references of flag_for_stochastic_spp_option to do_stochas…
JeffBeck-NOAA b939277
Update ccpp/physics pointer
JeffBeck-NOAA 1fff6af
Update ccpp/physics pointer
JeffBeck-NOAA a624fee
Update ccpp/physics pointer
JeffBeck-NOAA 786a066
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fea…
JeffBeck-NOAA 208e2c4
Update ccpp/physics pointer
JeffBeck-NOAA 8dd5e2a
Update ccpp-physics pointer and .gitmodules file
JeffBeck-NOAA ff03dc6
Change branch back to main
JeffBeck-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2296,6 +2296,71 @@ subroutine GFS_externaldiag_populate (ExtDiag, Model, Statein, Stateout, Sfcprop | |
enddo | ||
endif | ||
|
||
if (Model%do_spp) then | ||
idx = idx + 1 | ||
ExtDiag(idx)%axes = 3 | ||
ExtDiag(idx)%name = 'spp_wts_pbl' | ||
ExtDiag(idx)%desc = 'spp pbl perturbation wts' | ||
ExtDiag(idx)%unit = 'm/s' | ||
ExtDiag(idx)%mod_name = 'gfs_phys' | ||
allocate (ExtDiag(idx)%data(nblks)) | ||
do nb = 1,nblks | ||
ExtDiag(idx)%data(nb)%var3 => Coupling(nb)%spp_wts_pbl(:,:) | ||
enddo | ||
JeffBeck-NOAA marked this conversation as resolved.
Show resolved
Hide resolved
|
||
endif | ||
|
||
if (Model%do_spp) then | ||
idx = idx + 1 | ||
ExtDiag(idx)%axes = 3 | ||
ExtDiag(idx)%name = 'spp_wts_sfc' | ||
ExtDiag(idx)%desc = 'spp sfc perturbation wts' | ||
ExtDiag(idx)%unit = 'm/s' | ||
ExtDiag(idx)%mod_name = 'gfs_phys' | ||
allocate (ExtDiag(idx)%data(nblks)) | ||
do nb = 1,nblks | ||
ExtDiag(idx)%data(nb)%var3 => Coupling(nb)%spp_wts_sfc(:,:) | ||
enddo | ||
endif | ||
|
||
if (Model%do_spp) then | ||
idx = idx + 1 | ||
ExtDiag(idx)%axes = 3 | ||
ExtDiag(idx)%name = 'spp_wts_mp' | ||
ExtDiag(idx)%desc = 'spp mp perturbation wts' | ||
ExtDiag(idx)%unit = 'm/s' | ||
ExtDiag(idx)%mod_name = 'gfs_phys' | ||
allocate (ExtDiag(idx)%data(nblks)) | ||
do nb = 1,nblks | ||
ExtDiag(idx)%data(nb)%var3 => Coupling(nb)%spp_wts_mp(:,:) | ||
enddo | ||
endif | ||
|
||
if (Model%do_spp) then | ||
idx = idx + 1 | ||
ExtDiag(idx)%axes = 3 | ||
ExtDiag(idx)%name = 'spp_wts_gwd' | ||
ExtDiag(idx)%desc = 'spp gwd perturbation wts' | ||
ExtDiag(idx)%unit = 'm/s' | ||
ExtDiag(idx)%mod_name = 'gfs_phys' | ||
allocate (ExtDiag(idx)%data(nblks)) | ||
do nb = 1,nblks | ||
ExtDiag(idx)%data(nb)%var3 => Coupling(nb)%spp_wts_gwd(:,:) | ||
enddo | ||
endif | ||
|
||
if (Model%do_spp) then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Future cleanup. All these individual |
||
idx = idx + 1 | ||
ExtDiag(idx)%axes = 3 | ||
ExtDiag(idx)%name = 'spp_wts_rad' | ||
ExtDiag(idx)%desc = 'spp rad perturbation wts' | ||
ExtDiag(idx)%unit = 'm/s' | ||
ExtDiag(idx)%mod_name = 'gfs_phys' | ||
allocate (ExtDiag(idx)%data(nblks)) | ||
do nb = 1,nblks | ||
ExtDiag(idx)%data(nb)%var3 => Coupling(nb)%spp_wts_rad(:,:) | ||
enddo | ||
endif | ||
|
||
if (Model%lndp_type /= 0) then | ||
idx = idx + 1 | ||
ExtDiag(idx)%axes = 2 | ||
|
Submodule physics
updated
18 files
+22 −1 | physics/GFS_rrtmg_pre.F90 | |
+16 −1 | physics/GFS_rrtmg_pre.meta | |
+1 −1 | physics/GFS_surface_generic.meta | |
+35 −12 | physics/drag_suite.F90 | |
+15 −0 | physics/drag_suite.meta | |
+12 −9 | physics/module_MYNNPBL_wrapper.F90 | |
+15 −0 | physics/module_MYNNPBL_wrapper.meta | |
+7 −4 | physics/module_MYNNSFC_wrapper.F90 | |
+15 −0 | physics/module_MYNNSFC_wrapper.meta | |
+4 −3 | physics/module_bl_mynn.F90 | |
+5 −21 | physics/module_mp_thompson.F90 | |
+32 −32 | physics/module_sf_mynn.F90 | |
+17 −12 | physics/mp_thompson.F90 | |
+15 −0 | physics/mp_thompson.meta | |
+7 −2 | physics/ugwpv1_gsldrag.F90 | |
+15 −0 | physics/ugwpv1_gsldrag.meta | |
+6 −2 | physics/unified_ugwp.F90 | |
+15 −0 | physics/unified_ugwp.meta |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA Please change the branch back to the main branch. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Thank you!