Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused coupled suites #394

Closed

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 22, 2021

Description

Removes old GFS_v17 suite files for coupled model which are no longer required after the commit of the global P7 regression tests.

Issue(s) addressed

Testing

No testing required

Dependencies

  • waiting on ufs-weather PR #765

DeniseWorthen and others added 30 commits November 18, 2019 11:11
The HAFS related developments for the write_grid_component (#10)
change ifmin to zero at fh00 for inline POST (#14)
Update EMC dev/emc from NCAR dtc/develop 2019/12/17 (NOAA-EMC#30)
GFSv16 netcdf post ficein cpl (NOAA-EMC#48)
Regain bit-for-bit identical results between IPD and CCPP for coupled…
Merge NCAR:dtc/develop into develop 2020/04/14 (NOAA-EMC#98)
@junwang-noaa
Copy link
Collaborator

Do you want to remove the suite_FV3_GFS_v15p2_coupled.xml and suite_FV3_GFS_v15p2_couplednsst.xml too?

@JessicaMeixner-NOAA
Copy link
Collaborator

Do you want to remove the suite_FV3_GFS_v15p2_coupled.xml and suite_FV3_GFS_v15p2_couplednsst.xml too?

@bingfu-NOAA are you still using the suite_FV3_GFS_v15p2_coupled.xml and suite_FV3_GFS_v15p2_couplednsst.xml files?

@DeniseWorthen
Copy link
Collaborator Author

These are marked on the spreadsheet as still being required by the ensemble group.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 22, 2021 via email

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

@bingfu-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA @junwang-noaa I was using those suites for previous ensemble experiments. You may remove them if those old suites need to be removed, I have a copy so I can still use them later if I want.

@junwang-noaa
Copy link
Collaborator

@bingfu-NOAA Thanks. By the way, you can always check out old revisions to get these suite files, since we are not testing the physics packages in those suites, we don't know if they are working with the latest code or not.

@DeniseWorthen
Copy link
Collaborator Author

Close; changes were added to PR #404

@DeniseWorthen DeniseWorthen deleted the feature/removesuites branch October 9, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce number of CCPP suites after ufs-weather-model regression test update
5 participants