Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when running GFS PBL/sfclay and clm lake in RRFS ensemble #741

Closed
JiliDong-NOAA opened this issue Dec 19, 2023 · 0 comments · Fixed by #736
Closed

crash when running GFS PBL/sfclay and clm lake in RRFS ensemble #741

JiliDong-NOAA opened this issue Dec 19, 2023 · 0 comments · Fixed by #736
Labels
bug Something isn't working

Comments

@JiliDong-NOAA
Copy link
Contributor

JiliDong-NOAA commented Dec 19, 2023

Description

A couple of RRFS ensemble members crashed with GFS PBL (TKE-EDMF)/sfclay and clm lake combined. This happened when lake water was frozen to lake ice in clm lake.

The reason for the crash is because clm lake is called between surface layer scheme and PBL scheme. If there is a state change in clm lake, particularly water turning into ice, stability related variables over ice will be missing and cause the crash.
Please see the attached slides for more information.

clm_lake_bug_fix.pptx

To Reproduce:

  1. perform a forecast with GFS PBL/sfclayer combined with clm lake
  2. wait for lake water turning into lake ice, which could happen in winter time further north
  3. model crashed with AVOST error message from RUC LSM

Additional context

Add any other context about the problem here.
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • needs to be fixed also in noaa-emc/nems/issues/<issue_number>
  • needed for noaa-emc/fv3atm/pull/<pr_number>

Output

Screenshots
If applicable, drag and drop screenshots to help explain your problem.

output logs
If applicable, include relevant output logs.
Either drag and drop the entire log file here (if a long log) or

      AVOST IN VILKA     Table index=  -2147483648

 I,J=           1           1 LU_index =           17 Psfc[hPa] =

                     NaN Tsfc =    262.537014420372

Testing:

  1. Have you tested the code changes? On what platforms?
    Yes. On Hera.
  2. Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?
    Yes.
  • Will the baseline results change?
    No.
  • If the baseline results change, is it expected? Please give brief explanation.

Dependent PRs:

ufs-community/ccpp-physics#148

@JiliDong-NOAA JiliDong-NOAA added the bug Something isn't working label Dec 19, 2023
zach1221 pushed a commit to ufs-community/ufs-weather-model that referenced this issue Dec 21, 2023
…nodi + #2047, #2053, and #2056 (#2044)

FV3 diagnostic fixes, CCPP fixes for model crashes, new PR template

- UFS:
    - commit message in PR template (#2053)
    - fix hercules crashes (#2015)
- CMEPS & FV3: Bad data from in CCPP CLM Lake physics scheme caused model crashes
    - Communicate changes to lake ice (Closes #2055, NOAA-EMC/CMEPS#105, NOAA-EMC/fv3atm#741) 
    - unit mismatch (NOAA-EMC/fv3atm#736)
- FV3: correct errors in diagnostic calculations
    - snodi had weasdi data in it (NOAA-EMC/fv3atm#736)
    - revisions to RUC LSM snowfall melting and accumulation (NOAA-EMC/fv3atm#739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant