Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GNU make build #726

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Remove GNU make build #726

wants to merge 7 commits into from

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

Remove GNU make build

Description

This PR removes the GNU make build parts in the model/bin directory and cleans up the regression tests to only support the cmake build. It also adds documentation for CMAKE in the documentation (current work in progress).

Please also include the following information:

Issue(s) addressed

Commit Message

Remove GNU make build system and update documentation for CMAKE.

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@JessicaMeixner-NOAA
Copy link
Collaborator Author

This is currently a draft while the documentation gets updated. After I will run the tests. I thought I'd make a draft PR so everyone will get a preview of what is being removed as soon as possible.

@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jul 25, 2022
Closed
4 tasks
@aliabdolali aliabdolali mentioned this pull request Aug 15, 2022
Closed
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Sep 8, 2022
Closed
@JessicaMeixner-NOAA
Copy link
Collaborator Author

This PR is waiting on wiki and manual updates to document CMAKE. It will likely still be a few weeks before this is converted to a non-draft and merged in.

@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Sep 16, 2022
Open
JessicaMeixner-NOAA and others added 4 commits September 22, 2022 07:08
@JessicaMeixner-NOAA
Merge remote-tracking branch 'EMC/develop' into feature/removeGNUmake
c96ccc8 
Conflicts:
	model/bin/link.tmpl
	model/bin/make_makefile.sh
	model/bin/w3_new
	regtests/bin/matrix_cmake_datarmor
	regtests/bin/matrix_cmake_ncep
	regtests/bin/matrix_ncep
@JessicaMeixner-NOAA
Merge branch 'NOAA-EMC:develop' into feature/removeGNUmake
2e41271
@JessicaMeixner-NOAA
Merge remote-tracking branch 'EMC/develop' into feature/removeGNUmake
7db9720 
 Conflicts:
	model/bin/ad3.tmpl
	model/bin/all_switches
	model/bin/build_utils.sh
	model/bin/cmplr.env
	model/bin/comp.tmpl
	model/bin/find_switch
	model/bin/link.tmpl
	model/bin/make_makefile.sh
	model/bin/sort_all_switches
	model/bin/sort_switch
	model/bin/w3_automake
	model/bin/w3_make
	model/src/SCRIP/SCRIP.mk
	model/src/SCRIP/SCRIP_NC.mk
	regtests/bin/matrix_cmake_ncep
	regtests/bin/matrix_ncep
	regtests/bin/run_cmake_test
	regtests/bin/run_test
@JessicaMeixner-NOAA
remove cmake milhydro -> milhydro
85156d5
@ukmo-ccbunney
Copy link
Collaborator

Hi Jessica,
When you are updating the CMake documentation, it might be worth mentioning the use of "ToolChains" to control the build flags. This relates to Aron's question about "How to provide flags to CMake" - I added a reply in the thread here:

#822 (comment)

I currently use the toolchain method to override default flags on one of our systems and it works quite well.
It could also be a way for each of the "operational centres" to store their specific build flags (if we wish to do so).

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@ukmo-ccbunney great point! We can add this to a README if we'd like this to get into the repo sooner than later. Although I do hope to pick this back up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retire GNU build starting on June 1st, 2022
2 participants
@JessicaMeixner-NOAA @ukmo-ccbunney