Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate artificial supercooled water (rain and cloud) on pressure levels #771

Merged
merged 15 commits into from
Sep 25, 2023
Merged

Eliminate artificial supercooled water (rain and cloud) on pressure levels #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0fa1e2a
Updates to prevent spurious supercooled rain water from appearing on …
jaymes-kenyon Sep 6, 2023
777fd09
Updates to comments/documentation; fix to continuation line
jaymes-kenyon Sep 6, 2023
4253ec9
Fix typo in comments
jaymes-kenyon Sep 6, 2023
1153656
(1) Adding "IF MODELNAME" checks
jaymes-kenyon Sep 7, 2023
ffff4e2
Adding "MAX" functions, as are also used in the interpolation code (e…
jaymes-kenyon Sep 8, 2023
263da42
Restating freezing temperature as "TFRZ" (= 273.15 K, from params.F) …
jaymes-kenyon Sep 8, 2023
e1df9fd
Removing print statements; finalizing PR
jaymes-kenyon Sep 11, 2023
e702d73
(1) Refactoring logic,
jaymes-kenyon Sep 12, 2023
a2b0b1b
Updating entry in history log
jaymes-kenyon Sep 12, 2023
d695311
Re-wording comment
jaymes-kenyon Sep 12, 2023
5e8e011
For snow and graupel, use the value from the overlying model level or…
jaymes-kenyon Sep 14, 2023
bbf4f47
Merge branch 'develop' of https://github.com/NOAA-EMC/UPP into pressu…
jaymes-kenyon Sep 22, 2023
f879aa5
Adding bug fix from Wen
jaymes-kenyon Sep 22, 2023
2425400
Adding checks for undefined arrays.
jaymes-kenyon Sep 22, 2023
44d205c
Fix typo
jaymes-kenyon Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sorc/ncep_post.fd/INITPOST_NETCDF.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
!> 2023-07-24 | Hui-Ya Chuang | Bug fix in tke inialization
!> 2023-08-04 | Jaymes Kenyon | Read RRFS microphysics number concentrations (cloud water, cloud ice, rain)
!> 2023-08-31 | Li(Kate Zhang)| Add condition to include/exclude processing nitrate from model output
!> 2023-09-22 | Wen Meng | Bug fix in cwm intialization
!>
!> @author Hui-Ya Chuang @date 2016-03-04
!----------------------------------------------------------------------
Expand Down Expand Up @@ -914,8 +915,10 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
do l=1,lm
do j=jsta,jend
do i=ista,iend
qrmax(i,j)=max(qrmax(i,j),qqr(i,j,l))
cwm(i,j,l)=qqg(i,j,l)+qqs(i,j,l)+qqr(i,j,l)+qqi(i,j,l)+qqw(i,j,l)
if(qqr(i,j,l) /= spval) then
qrmax(i,j)=max(qrmax(i,j),qqr(i,j,l))
cwm(i,j,l)=qqg(i,j,l)+qqs(i,j,l)+qqr(i,j,l)+qqi(i,j,l)+qqw(i,j,l)
endif
enddo
enddo
if(debugprint)print*,'sample l,t,q,u,v,w= ',isa,jsa,l &
Expand Down
65 changes: 64 additions & 1 deletion sorc/ncep_post.fd/MDL2P.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
!> 2022-12-21 | J Meng ! Adding snow density SDEN
!> 2023-02-23 | E James | Adding coarse PM from RRFS
!> 2023-08-24 | Y Mao | Add gtg_on option for GTG interpolation
!> 2023-09-12 | J Kenyon | Prevent spurious supercooled rain and cloud water
!>
!> @author T Black W/NP2 @date 1999-09-23
!--------------------------------------------------------------------------------------
Expand Down Expand Up @@ -64,7 +65,7 @@ SUBROUTINE MDL2P(iostatusD3D)
use physcons_post,only: CON_FVIRT, CON_ROG, CON_EPS, CON_EPSM1
use params_mod, only: H1M12, DBZMIN, H1, PQ0, A2, A3, A4, RHMIN, G, &
RGAMOG, RD, D608, GI, ERAD, PI, SMALL, H100, &
H99999, GAMMA
H99999, GAMMA, TFRZ
use ctlblk_mod, only: MODELNAME, LP1, ME, JSTA, JEND, LM, SPVAL, SPL, &
ALSL, JEND_M, SMFLAG, GRIB, CFLD, FLD_INFO, DATAPD,&
TD3D, IFHR, IFMIN, IM, JM, NBIN_DU, JSTA_2L, &
Expand Down Expand Up @@ -532,6 +533,68 @@ SUBROUTINE MDL2P(iostatusD3D)
QG1(I,J) = QQG(I,J,LL) + (QQG(I,J,LL)-QQG(I,J,LL-1))*FACT
QG1(I,J) = MAX(QG1(I,J),zero) ! GRAUPEL (precip ice)

! ...Prevent spurious supercooled water (rain and
! cloud water) from appearing on pressure levels
! that are located just above melting levels...
!
! Added Sep 2023 by J. Kenyon (NOAA/GSL), in response to
! a problem identified by G. Thompson (NCAR), described
! below.
!
! Consider a situation in which:
! (1) the target pressure level is contained between
! two adjacent model levels that also contain a
! melting level; i.e., the overlying model level
! is subfreezing, and the underlying model level
! is above freezing.
! (2) the temperature on the target pressure level
! (via interpolation) is subfreezing; i.e., the
! target pressure level is located "just above"
! the aforementioned melting level.
! (3) rain water exists on the underlying model level
!
! This situation is often found in a classic melting-
! snow thermal profile. The model level above the
! melting level will typically contain snow, but no
! rain. Meanwhile, the model level below the melting
! level will contain rain. Importantly, model levels in
! this situation do not contain supercooled rain, but
! interpolation onto the target pressure level will
! yield supercooled rain. In this sense, the supercooled
! rain is an artifact of interpolation. Because
! supercooled water poses a hazard to aviation, we seek
! to prevent supercooled water on pressure levels
! when none actually exists on the adjacent model levels.
!
! In the code below, we search for the condition in
! which this artifact occurs. Then, the previously
! interpolated value of Qrain is simply replaced by the
! value from the overlying (subfreezing) model level.
! The same approach is used for cloud water and cloud
! ice. However, for snow and graupel, either the value from
! the overlying model level or the interpolated value
! is used, whichever is greater. Since model-level weighting
! depends on the hydrometeor species, it is possible
! that the total condensate on the pressure level may be
! greater or less than that on both adjacent model levels
! (i.e., a slight artificial gain/loss of total condensate
! is possible). If this behavior must be avoided, simply
! use the values from the overlying model level for
! all species.
IF (MODELNAME == 'FV3R' .OR. MODELNAME == 'GFS') THEN
IF ( TSL(I,J) <= TFRZ .AND. & ! This pressure level is subfreezing and located just above a melting level;
T(I,J,LL-1) <= TFRZ .AND. & ! i.e., the overlying model level is subfreezing,
T(I,J,LL) > TFRZ ) THEN ! but the underlying model level is above freezing.
IF (QW1(I,J)<SPVAL) QW1(I,J) = MAX(QQW(I,J,LL-1),zero) ! For cloud water, cloud ice, and rain,
IF (QI1(I,J)<SPVAL) QI1(I,J) = MAX(QQI(I,J,LL-1),zero) ! use the value from the overlying (subfreezing) model
IF (QR1(I,J)<SPVAL) QR1(I,J) = MAX(QQR(I,J,LL-1),zero) ! level.
IF (QS1(I,J)<SPVAL) QS1(I,J) = MAX(QQS(I,J,LL-1),QS1(I,J))! For snow and graupel, use the value from the overlying
IF (QG1(I,J)<SPVAL) QG1(I,J) = MAX(QQG(I,J,LL-1),QG1(I,J))! level or the interpolated value, whichever is greater.
IF (C1D(I,J)<SPVAL) C1D(I,J) = QG1(I,J)+QS1(I,J)+QR1(I,J)+QI1(I,J)+QW1(I,J) ! Recalculate total condensate
ENDIF
ENDIF
! End of code to prevent spurious supercooled water

IF(DBZ(I,J,LL) < SPVAL .AND. DBZ(I,J,LL-1) < SPVAL) &
DBZ1(I,J) = DBZ(I,J,LL) + (DBZ(I,J,LL)-DBZ(I,J,LL-1))*FACT
DBZ1(I,J) = MAX(DBZ1(I,J),DBZmin)
Expand Down
Loading